<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Aug 20, 2015, at 9:46 PM, Josh Gao <<a href="mailto:jmgao@google.com" class="">jmgao@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">Sorry about that, </div></div></blockquote>No problem. It just passed again now so its all good.<br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" class="">I didn't realize that only ELF supported function aliases.</div></div></blockquote>Me neither. I’d have caused the same error had i implemented this.</div><div><br class=""></div><div>Pete<br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""><div class=""><br class=""></div><div class="">-Josh</div></div><div class="gmail_extra"><br class=""><div class="gmail_quote">On Thu, Aug 20, 2015 at 9:42 PM, Pete Cooper <span dir="ltr" class=""><<a href="mailto:peter_cooper@apple.com" target="_blank" class="">peter_cooper@apple.com</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word" class=""><br class=""><div class=""><span class=""><blockquote type="cite" class=""><div class="">On Aug 20, 2015, at 9:41 PM, Saleem Abdulrasool <<a href="mailto:compnerd@compnerd.org" target="_blank" class="">compnerd@compnerd.org</a>> wrote:</div><br class=""><div class=""><div dir="ltr" style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px" class="">On Thu, Aug 20, 2015 at 9:02 PM, Pete Cooper via llvm-commits<span class=""> </span><span dir="ltr" class=""><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@lists.llvm.org</a>></span><span class=""> </span>wrote:<br class=""><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">Hi Josh<br class=""><br class="">We’re getting a Darwin bot failure with this commit. Any chance you can take a look?<br class=""></blockquote><div class=""><br class=""></div><div class="">It should be fixed with SVN r245669. </div></div></div></div></div></blockquote></span>Great. Thanks very much for the quick fix. I’ll keep an eye on the bots.<span class=""><br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px" class=""><div class="gmail_extra"><div class="gmail_quote"><div class="">It would break on any non-ELF target, since it is the only one to support aliases.</div></div></div></div></div></blockquote></span>Interesting. I didn’t know that.</div><div class=""><br class=""></div><div class="">Thanks,</div><div class="">Pete<div class=""><div class="h5"><br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px" class=""><div class="gmail_extra"><div class="gmail_quote"><div class=""> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">One of the errors is this, I think the others are similar, and likely all from the same macro.<br class=""><br class="">compiler-rt/lib/builtins/comparedf2.c:84:1: error: only weak aliases are supported on darwin<br class=""><br class="">FNALIAS(__cmpdf2, __ledf2);<br class="">^<br class="">compiler-rt/lib/builtins/int_lib.h:24:36: note: expanded from macro 'FNALIAS'<br class=""> <span class=""> </span>void alias_name() __attribute__((alias(#original_name)))<br class=""><br class="">Cheers,<br class="">Pete<br class=""><span class="">> On Aug 20, 2015, at 7:51 PM, Josh Gao via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@lists.llvm.org</a>> wrote:<br class="">><br class="">> Author: jmgao<br class="">> Date: Thu Aug 20 21:51:17 2015<br class="">> New Revision: 245663<br class="">><br class=""></span>> URL:<span class=""> </span><a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject-3Frev-3D245663-26view-3Drev&d=BQIGaQ&c=eEvniauFctOgLOKGJOplqw&r=03tkj3107244TlY4t3_hEgkDY-UG6gKwwK0wOUS3qjM&m=BB2VwxEuZugRrby1sA0WX7Xsamu41YWpfZuyGvNnlWc&s=76UfhTPqOuLhN_NCHR4WLwO8xHZddsYSes7fzxcX6_w&e=" rel="noreferrer" target="_blank" class="">https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject-3Frev-3D245663-26view-3Drev&d=BQIGaQ&c=eEvniauFctOgLOKGJOplqw&r=03tkj3107244TlY4t3_hEgkDY-UG6gKwwK0wOUS3qjM&m=BB2VwxEuZugRrby1sA0WX7Xsamu41YWpfZuyGvNnlWc&s=76UfhTPqOuLhN_NCHR4WLwO8xHZddsYSes7fzxcX6_w&e=</a><br class=""><span class="">> Log:<br class="">> [compiler-rt] Add libgcc compatibility aliases for __cmp{s,d,f}f2.<br class="">><br class="">> Reviewers: compnerd<br class="">><br class="">> Subscribers: asl, llvm-commits<br class="">><br class=""></span>> Differential Revision:<span class=""> </span><a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_D12091&d=BQIGaQ&c=eEvniauFctOgLOKGJOplqw&r=03tkj3107244TlY4t3_hEgkDY-UG6gKwwK0wOUS3qjM&m=BB2VwxEuZugRrby1sA0WX7Xsamu41YWpfZuyGvNnlWc&s=NGbTwVkyT6chsOrbX9sKlGh5vfLXVArge-jxlDsw4As&e=" rel="noreferrer" target="_blank" class="">https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_D12091&d=BQIGaQ&c=eEvniauFctOgLOKGJOplqw&r=03tkj3107244TlY4t3_hEgkDY-UG6gKwwK0wOUS3qjM&m=BB2VwxEuZugRrby1sA0WX7Xsamu41YWpfZuyGvNnlWc&s=NGbTwVkyT6chsOrbX9sKlGh5vfLXVArge-jxlDsw4As&e=</a><br class=""><span class="">><br class="">> Modified:<br class="">> compiler-rt/trunk/lib/builtins/comparedf2.c<br class="">> compiler-rt/trunk/lib/builtins/comparesf2.c<br class="">> compiler-rt/trunk/lib/builtins/comparetf2.c<br class="">> compiler-rt/trunk/lib/builtins/int_lib.h<br class="">><br class="">> Modified: compiler-rt/trunk/lib/builtins/comparedf2.c<br class=""></span>> URL:<span class=""> </span><a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_compiler-2Drt_trunk_lib_builtins_comparedf2.c-3Frev-3D245663-26r1-3D245662-26r2-3D245663-26view-3Ddiff&d=BQIGaQ&c=eEvniauFctOgLOKGJOplqw&r=03tkj3107244TlY4t3_hEgkDY-UG6gKwwK0wOUS3qjM&m=BB2VwxEuZugRrby1sA0WX7Xsamu41YWpfZuyGvNnlWc&s=vKCxo9dJc8LlhXmSkrrD6xKixY-T23dgUmVcHKTR78M&e=" rel="noreferrer" target="_blank" class="">https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_compiler-2Drt_trunk_lib_builtins_comparedf2.c-3Frev-3D245663-26r1-3D245662-26r2-3D245663-26view-3Ddiff&d=BQIGaQ&c=eEvniauFctOgLOKGJOplqw&r=03tkj3107244TlY4t3_hEgkDY-UG6gKwwK0wOUS3qjM&m=BB2VwxEuZugRrby1sA0WX7Xsamu41YWpfZuyGvNnlWc&s=vKCxo9dJc8LlhXmSkrrD6xKixY-T23dgUmVcHKTR78M&e=</a><br class=""><span class="">> ==============================================================================<br class="">> --- compiler-rt/trunk/lib/builtins/comparedf2.c (original)<br class="">> +++ compiler-rt/trunk/lib/builtins/comparedf2.c Thu Aug 20 21:51:17 2015<br class="">> @@ -80,6 +80,9 @@ __ledf2(fp_t a, fp_t b) {<br class="">> }<br class="">> }<br class="">><br class="">> +// Alias for libgcc compatibility<br class="">> +FNALIAS(__cmpdf2, __ledf2);<br class="">> +<br class="">> enum GE_RESULT {<br class="">> GE_LESS = -1,<br class="">> GE_EQUAL = 0,<br class="">><br class="">> Modified: compiler-rt/trunk/lib/builtins/comparesf2.c<br class=""></span>> URL:<span class=""> </span><a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_compiler-2Drt_trunk_lib_builtins_comparesf2.c-3Frev-3D245663-26r1-3D245662-26r2-3D245663-26view-3Ddiff&d=BQIGaQ&c=eEvniauFctOgLOKGJOplqw&r=03tkj3107244TlY4t3_hEgkDY-UG6gKwwK0wOUS3qjM&m=BB2VwxEuZugRrby1sA0WX7Xsamu41YWpfZuyGvNnlWc&s=RPQq3PpFJoeOht-jTLWgtVATweLX6p0WDGYrRhaN5Gg&e=" rel="noreferrer" target="_blank" class="">https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_compiler-2Drt_trunk_lib_builtins_comparesf2.c-3Frev-3D245663-26r1-3D245662-26r2-3D245663-26view-3Ddiff&d=BQIGaQ&c=eEvniauFctOgLOKGJOplqw&r=03tkj3107244TlY4t3_hEgkDY-UG6gKwwK0wOUS3qjM&m=BB2VwxEuZugRrby1sA0WX7Xsamu41YWpfZuyGvNnlWc&s=RPQq3PpFJoeOht-jTLWgtVATweLX6p0WDGYrRhaN5Gg&e=</a><br class=""><span class="">> ==============================================================================<br class="">> --- compiler-rt/trunk/lib/builtins/comparesf2.c (original)<br class="">> +++ compiler-rt/trunk/lib/builtins/comparesf2.c Thu Aug 20 21:51:17 2015<br class="">> @@ -80,6 +80,9 @@ __lesf2(fp_t a, fp_t b) {<br class="">> }<br class="">> }<br class="">><br class="">> +// Alias for libgcc compatibility<br class="">> +FNALIAS(__cmpsf2, __lesf2);<br class="">> +<br class="">> enum GE_RESULT {<br class="">> GE_LESS = -1,<br class="">> GE_EQUAL = 0,<br class="">><br class="">> Modified: compiler-rt/trunk/lib/builtins/comparetf2.c<br class=""></span>> URL:<span class=""> </span><a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_compiler-2Drt_trunk_lib_builtins_comparetf2.c-3Frev-3D245663-26r1-3D245662-26r2-3D245663-26view-3Ddiff&d=BQIGaQ&c=eEvniauFctOgLOKGJOplqw&r=03tkj3107244TlY4t3_hEgkDY-UG6gKwwK0wOUS3qjM&m=BB2VwxEuZugRrby1sA0WX7Xsamu41YWpfZuyGvNnlWc&s=ukLelFyM4yR8JHDkKExIxb_PCAAfVdmmCvupWO9Tzxk&e=" rel="noreferrer" target="_blank" class="">https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_compiler-2Drt_trunk_lib_builtins_comparetf2.c-3Frev-3D245663-26r1-3D245662-26r2-3D245663-26view-3Ddiff&d=BQIGaQ&c=eEvniauFctOgLOKGJOplqw&r=03tkj3107244TlY4t3_hEgkDY-UG6gKwwK0wOUS3qjM&m=BB2VwxEuZugRrby1sA0WX7Xsamu41YWpfZuyGvNnlWc&s=ukLelFyM4yR8JHDkKExIxb_PCAAfVdmmCvupWO9Tzxk&e=</a><br class=""><span class="">> ==============================================================================<br class="">> --- compiler-rt/trunk/lib/builtins/comparetf2.c (original)<br class="">> +++ compiler-rt/trunk/lib/builtins/comparetf2.c Thu Aug 20 21:51:17 2015<br class="">> @@ -79,6 +79,9 @@ COMPILER_RT_ABI enum LE_RESULT __letf2(f<br class="">> }<br class="">> }<br class="">><br class="">> +// Alias for libgcc compatibility<br class="">> +FNALIAS(__cmptf2, __letf2);<br class="">> +<br class="">> enum GE_RESULT {<br class="">> GE_LESS = -1,<br class="">> GE_EQUAL = 0,<br class="">><br class="">> Modified: compiler-rt/trunk/lib/builtins/int_lib.h<br class=""></span>> URL:<span class=""> </span><a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_compiler-2Drt_trunk_lib_builtins_int-5Flib.h-3Frev-3D245663-26r1-3D245662-26r2-3D245663-26view-3Ddiff&d=BQIGaQ&c=eEvniauFctOgLOKGJOplqw&r=03tkj3107244TlY4t3_hEgkDY-UG6gKwwK0wOUS3qjM&m=BB2VwxEuZugRrby1sA0WX7Xsamu41YWpfZuyGvNnlWc&s=XiCSfg9LKmkG1BdWSrdiglTtdTouCdFzFWC8El7o-As&e=" rel="noreferrer" target="_blank" class="">https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_compiler-2Drt_trunk_lib_builtins_int-5Flib.h-3Frev-3D245663-26r1-3D245662-26r2-3D245663-26view-3Ddiff&d=BQIGaQ&c=eEvniauFctOgLOKGJOplqw&r=03tkj3107244TlY4t3_hEgkDY-UG6gKwwK0wOUS3qjM&m=BB2VwxEuZugRrby1sA0WX7Xsamu41YWpfZuyGvNnlWc&s=XiCSfg9LKmkG1BdWSrdiglTtdTouCdFzFWC8El7o-As&e=</a><br class=""><span class="">> ==============================================================================<br class="">> --- compiler-rt/trunk/lib/builtins/int_lib.h (original)<br class="">> +++ compiler-rt/trunk/lib/builtins/int_lib.h Thu Aug 20 21:51:17 2015<br class="">> @@ -20,6 +20,9 @@<br class="">> /* Assumption: Right shift of signed negative is arithmetic shift. */<br class="">> /* Assumption: Endianness is little or big (not mixed). */<br class="">><br class="">> +#define FNALIAS(alias_name, original_name) \<br class="">> + void alias_name() __attribute__((alias(#original_name)))<br class="">> +<br class="">> /* ABI macro definitions */<br class="">><br class="">> #if __ARM_EABI__<br class="">><br class="">><br class="">> _______________________________________________<br class="">> llvm-commits mailing list<br class="">><span class=""> </span><a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@lists.llvm.org</a><br class=""></span>><span class=""> </span><a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.llvm.org_cgi-2Dbin_mailman_listinfo_llvm-2Dcommits&d=BQIGaQ&c=eEvniauFctOgLOKGJOplqw&r=03tkj3107244TlY4t3_hEgkDY-UG6gKwwK0wOUS3qjM&m=BB2VwxEuZugRrby1sA0WX7Xsamu41YWpfZuyGvNnlWc&s=-Na1POe5DXysRwtYGz3X6CHnSiIa22KXVLsg2I8xioY&e=" rel="noreferrer" target="_blank" class="">https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.llvm.org_cgi-2Dbin_mailman_listinfo_llvm-2Dcommits&d=BQIGaQ&c=eEvniauFctOgLOKGJOplqw&r=03tkj3107244TlY4t3_hEgkDY-UG6gKwwK0wOUS3qjM&m=BB2VwxEuZugRrby1sA0WX7Xsamu41YWpfZuyGvNnlWc&s=-Na1POe5DXysRwtYGz3X6CHnSiIa22KXVLsg2I8xioY&e=</a><br class=""><div class=""><div class=""><br class="">_______________________________________________<br class="">llvm-commits mailing list<br class=""><a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@lists.llvm.org</a><br class=""><a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.llvm.org_cgi-2Dbin_mailman_listinfo_llvm-2Dcommits&d=BQMFaQ&c=eEvniauFctOgLOKGJOplqw&r=03tkj3107244TlY4t3_hEgkDY-UG6gKwwK0wOUS3qjM&m=x2nRpSZDJ_RhrFSuiOk5NxVdJ6GlsxguUhHShRVl_kk&s=jmOyj81_ooo6fLX2aZP11YdqkHxxw24nRAHPvnTvYfQ&e=" rel="noreferrer" target="_blank" class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br class=""></div></div></blockquote></div><br class=""><br clear="all" class=""><div class=""><br class=""></div>--<span class=""> </span><br class=""><div class="">Saleem Abdulrasool<br class="">compnerd (at) compnerd (dot) org</div></div></div></div></blockquote></div></div></div><br class=""></div></blockquote></div><br class=""></div>
</div></blockquote></div><br class=""></body></html>