<div dir="ltr">On Thu, Aug 20, 2015 at 9:02 PM, Pete Cooper via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Josh<br>
<br>
We’re getting a Darwin bot failure with this commit. Any chance you can take a look?<br></blockquote><div><br></div><div>It should be fixed with SVN r245669. It would break on any non-ELF target, since it is the only one to support aliases.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
One of the errors is this, I think the others are similar, and likely all from the same macro.<br>
<br>
compiler-rt/lib/builtins/comparedf2.c:84:1: error: only weak aliases are supported on darwin<br>
<br>
FNALIAS(__cmpdf2, __ledf2);<br>
^<br>
compiler-rt/lib/builtins/int_lib.h:24:36: note: expanded from macro 'FNALIAS'<br>
void alias_name() __attribute__((alias(#original_name)))<br>
<br>
Cheers,<br>
Pete<br>
<span class="">> On Aug 20, 2015, at 7:51 PM, Josh Gao via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br>
><br>
> Author: jmgao<br>
> Date: Thu Aug 20 21:51:17 2015<br>
> New Revision: 245663<br>
><br>
</span>> URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject-3Frev-3D245663-26view-3Drev&d=BQIGaQ&c=eEvniauFctOgLOKGJOplqw&r=03tkj3107244TlY4t3_hEgkDY-UG6gKwwK0wOUS3qjM&m=BB2VwxEuZugRrby1sA0WX7Xsamu41YWpfZuyGvNnlWc&s=76UfhTPqOuLhN_NCHR4WLwO8xHZddsYSes7fzxcX6_w&e=" rel="noreferrer" target="_blank">https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject-3Frev-3D245663-26view-3Drev&d=BQIGaQ&c=eEvniauFctOgLOKGJOplqw&r=03tkj3107244TlY4t3_hEgkDY-UG6gKwwK0wOUS3qjM&m=BB2VwxEuZugRrby1sA0WX7Xsamu41YWpfZuyGvNnlWc&s=76UfhTPqOuLhN_NCHR4WLwO8xHZddsYSes7fzxcX6_w&e=</a><br>
<span class="">> Log:<br>
> [compiler-rt] Add libgcc compatibility aliases for __cmp{s,d,f}f2.<br>
><br>
> Reviewers: compnerd<br>
><br>
> Subscribers: asl, llvm-commits<br>
><br>
</span>> Differential Revision: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_D12091&d=BQIGaQ&c=eEvniauFctOgLOKGJOplqw&r=03tkj3107244TlY4t3_hEgkDY-UG6gKwwK0wOUS3qjM&m=BB2VwxEuZugRrby1sA0WX7Xsamu41YWpfZuyGvNnlWc&s=NGbTwVkyT6chsOrbX9sKlGh5vfLXVArge-jxlDsw4As&e=" rel="noreferrer" target="_blank">https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_D12091&d=BQIGaQ&c=eEvniauFctOgLOKGJOplqw&r=03tkj3107244TlY4t3_hEgkDY-UG6gKwwK0wOUS3qjM&m=BB2VwxEuZugRrby1sA0WX7Xsamu41YWpfZuyGvNnlWc&s=NGbTwVkyT6chsOrbX9sKlGh5vfLXVArge-jxlDsw4As&e=</a><br>
<span class="">><br>
> Modified:<br>
> compiler-rt/trunk/lib/builtins/comparedf2.c<br>
> compiler-rt/trunk/lib/builtins/comparesf2.c<br>
> compiler-rt/trunk/lib/builtins/comparetf2.c<br>
> compiler-rt/trunk/lib/builtins/int_lib.h<br>
><br>
> Modified: compiler-rt/trunk/lib/builtins/comparedf2.c<br>
</span>> URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_compiler-2Drt_trunk_lib_builtins_comparedf2.c-3Frev-3D245663-26r1-3D245662-26r2-3D245663-26view-3Ddiff&d=BQIGaQ&c=eEvniauFctOgLOKGJOplqw&r=03tkj3107244TlY4t3_hEgkDY-UG6gKwwK0wOUS3qjM&m=BB2VwxEuZugRrby1sA0WX7Xsamu41YWpfZuyGvNnlWc&s=vKCxo9dJc8LlhXmSkrrD6xKixY-T23dgUmVcHKTR78M&e=" rel="noreferrer" target="_blank">https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_compiler-2Drt_trunk_lib_builtins_comparedf2.c-3Frev-3D245663-26r1-3D245662-26r2-3D245663-26view-3Ddiff&d=BQIGaQ&c=eEvniauFctOgLOKGJOplqw&r=03tkj3107244TlY4t3_hEgkDY-UG6gKwwK0wOUS3qjM&m=BB2VwxEuZugRrby1sA0WX7Xsamu41YWpfZuyGvNnlWc&s=vKCxo9dJc8LlhXmSkrrD6xKixY-T23dgUmVcHKTR78M&e=</a><br>
<span class="">> ==============================================================================<br>
> --- compiler-rt/trunk/lib/builtins/comparedf2.c (original)<br>
> +++ compiler-rt/trunk/lib/builtins/comparedf2.c Thu Aug 20 21:51:17 2015<br>
> @@ -80,6 +80,9 @@ __ledf2(fp_t a, fp_t b) {<br>
> }<br>
> }<br>
><br>
> +// Alias for libgcc compatibility<br>
> +FNALIAS(__cmpdf2, __ledf2);<br>
> +<br>
> enum GE_RESULT {<br>
> GE_LESS = -1,<br>
> GE_EQUAL = 0,<br>
><br>
> Modified: compiler-rt/trunk/lib/builtins/comparesf2.c<br>
</span>> URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_compiler-2Drt_trunk_lib_builtins_comparesf2.c-3Frev-3D245663-26r1-3D245662-26r2-3D245663-26view-3Ddiff&d=BQIGaQ&c=eEvniauFctOgLOKGJOplqw&r=03tkj3107244TlY4t3_hEgkDY-UG6gKwwK0wOUS3qjM&m=BB2VwxEuZugRrby1sA0WX7Xsamu41YWpfZuyGvNnlWc&s=RPQq3PpFJoeOht-jTLWgtVATweLX6p0WDGYrRhaN5Gg&e=" rel="noreferrer" target="_blank">https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_compiler-2Drt_trunk_lib_builtins_comparesf2.c-3Frev-3D245663-26r1-3D245662-26r2-3D245663-26view-3Ddiff&d=BQIGaQ&c=eEvniauFctOgLOKGJOplqw&r=03tkj3107244TlY4t3_hEgkDY-UG6gKwwK0wOUS3qjM&m=BB2VwxEuZugRrby1sA0WX7Xsamu41YWpfZuyGvNnlWc&s=RPQq3PpFJoeOht-jTLWgtVATweLX6p0WDGYrRhaN5Gg&e=</a><br>
<span class="">> ==============================================================================<br>
> --- compiler-rt/trunk/lib/builtins/comparesf2.c (original)<br>
> +++ compiler-rt/trunk/lib/builtins/comparesf2.c Thu Aug 20 21:51:17 2015<br>
> @@ -80,6 +80,9 @@ __lesf2(fp_t a, fp_t b) {<br>
> }<br>
> }<br>
><br>
> +// Alias for libgcc compatibility<br>
> +FNALIAS(__cmpsf2, __lesf2);<br>
> +<br>
> enum GE_RESULT {<br>
> GE_LESS = -1,<br>
> GE_EQUAL = 0,<br>
><br>
> Modified: compiler-rt/trunk/lib/builtins/comparetf2.c<br>
</span>> URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_compiler-2Drt_trunk_lib_builtins_comparetf2.c-3Frev-3D245663-26r1-3D245662-26r2-3D245663-26view-3Ddiff&d=BQIGaQ&c=eEvniauFctOgLOKGJOplqw&r=03tkj3107244TlY4t3_hEgkDY-UG6gKwwK0wOUS3qjM&m=BB2VwxEuZugRrby1sA0WX7Xsamu41YWpfZuyGvNnlWc&s=ukLelFyM4yR8JHDkKExIxb_PCAAfVdmmCvupWO9Tzxk&e=" rel="noreferrer" target="_blank">https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_compiler-2Drt_trunk_lib_builtins_comparetf2.c-3Frev-3D245663-26r1-3D245662-26r2-3D245663-26view-3Ddiff&d=BQIGaQ&c=eEvniauFctOgLOKGJOplqw&r=03tkj3107244TlY4t3_hEgkDY-UG6gKwwK0wOUS3qjM&m=BB2VwxEuZugRrby1sA0WX7Xsamu41YWpfZuyGvNnlWc&s=ukLelFyM4yR8JHDkKExIxb_PCAAfVdmmCvupWO9Tzxk&e=</a><br>
<span class="">> ==============================================================================<br>
> --- compiler-rt/trunk/lib/builtins/comparetf2.c (original)<br>
> +++ compiler-rt/trunk/lib/builtins/comparetf2.c Thu Aug 20 21:51:17 2015<br>
> @@ -79,6 +79,9 @@ COMPILER_RT_ABI enum LE_RESULT __letf2(f<br>
> }<br>
> }<br>
><br>
> +// Alias for libgcc compatibility<br>
> +FNALIAS(__cmptf2, __letf2);<br>
> +<br>
> enum GE_RESULT {<br>
> GE_LESS = -1,<br>
> GE_EQUAL = 0,<br>
><br>
> Modified: compiler-rt/trunk/lib/builtins/int_lib.h<br>
</span>> URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_compiler-2Drt_trunk_lib_builtins_int-5Flib.h-3Frev-3D245663-26r1-3D245662-26r2-3D245663-26view-3Ddiff&d=BQIGaQ&c=eEvniauFctOgLOKGJOplqw&r=03tkj3107244TlY4t3_hEgkDY-UG6gKwwK0wOUS3qjM&m=BB2VwxEuZugRrby1sA0WX7Xsamu41YWpfZuyGvNnlWc&s=XiCSfg9LKmkG1BdWSrdiglTtdTouCdFzFWC8El7o-As&e=" rel="noreferrer" target="_blank">https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_compiler-2Drt_trunk_lib_builtins_int-5Flib.h-3Frev-3D245663-26r1-3D245662-26r2-3D245663-26view-3Ddiff&d=BQIGaQ&c=eEvniauFctOgLOKGJOplqw&r=03tkj3107244TlY4t3_hEgkDY-UG6gKwwK0wOUS3qjM&m=BB2VwxEuZugRrby1sA0WX7Xsamu41YWpfZuyGvNnlWc&s=XiCSfg9LKmkG1BdWSrdiglTtdTouCdFzFWC8El7o-As&e=</a><br>
<span class="">> ==============================================================================<br>
> --- compiler-rt/trunk/lib/builtins/int_lib.h (original)<br>
> +++ compiler-rt/trunk/lib/builtins/int_lib.h Thu Aug 20 21:51:17 2015<br>
> @@ -20,6 +20,9 @@<br>
> /* Assumption: Right shift of signed negative is arithmetic shift. */<br>
> /* Assumption: Endianness is little or big (not mixed). */<br>
><br>
> +#define FNALIAS(alias_name, original_name) \<br>
> + void alias_name() __attribute__((alias(#original_name)))<br>
> +<br>
> /* ABI macro definitions */<br>
><br>
> #if __ARM_EABI__<br>
><br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
</span>> <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.llvm.org_cgi-2Dbin_mailman_listinfo_llvm-2Dcommits&d=BQIGaQ&c=eEvniauFctOgLOKGJOplqw&r=03tkj3107244TlY4t3_hEgkDY-UG6gKwwK0wOUS3qjM&m=BB2VwxEuZugRrby1sA0WX7Xsamu41YWpfZuyGvNnlWc&s=-Na1POe5DXysRwtYGz3X6CHnSiIa22KXVLsg2I8xioY&e=" rel="noreferrer" target="_blank">https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.llvm.org_cgi-2Dbin_mailman_listinfo_llvm-2Dcommits&d=BQIGaQ&c=eEvniauFctOgLOKGJOplqw&r=03tkj3107244TlY4t3_hEgkDY-UG6gKwwK0wOUS3qjM&m=BB2VwxEuZugRrby1sA0WX7Xsamu41YWpfZuyGvNnlWc&s=-Na1POe5DXysRwtYGz3X6CHnSiIa22KXVLsg2I8xioY&e=</a><br>
<div class="HOEnZb"><div class="h5"><br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature">Saleem Abdulrasool<br>compnerd (at) compnerd (dot) org</div>
</div></div>