<div dir="ltr">I was actually surprised i didn't get a warning about that, and assumed it was OK as a consequence...<div><br></div><div>I think it is OK, but not because you're wrong. I think you're right, and we just happen to never, ever call these methods on anything but the base class type, and so it doesn't "matter". Still, using declarations are probably in order for sanity.</div></div><br><div class="gmail_quote"><div dir="ltr">On Fri, Aug 14, 2015 at 11:07 AM David Blaikie <<a href="mailto:dblaikie@gmail.com">dblaikie@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Fri, Aug 14, 2015 at 1:39 AM, Chandler Carruth via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: chandlerc<br>
Date: Fri Aug 14 03:39:32 2015<br>
New Revision: 245034<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=245034&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=245034&view=rev</a><br>
Log:<br>
[PM/AA] Remove two no-op overridden functions that just delegated to the<br>
base class anyways.<br></blockquote></div></div></div><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div><br>I imagine these might end up shadowed by the function of the same name in the derived class, and a "using base::func" might be needed to make sure they act as equal overloads on the derived type? (I saw a similar bit of code in another API yesterday)<br> </div></div></div></div><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Modified:<br>
    llvm/trunk/include/llvm/Analysis/GlobalsModRef.h<br>
    llvm/trunk/include/llvm/Analysis/LibCallAliasAnalysis.h<br>
<br>
Modified: llvm/trunk/include/llvm/Analysis/GlobalsModRef.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Analysis/GlobalsModRef.h?rev=245034&r1=245033&r2=245034&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Analysis/GlobalsModRef.h?rev=245034&r1=245033&r2=245034&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/include/llvm/Analysis/GlobalsModRef.h (original)<br>
+++ llvm/trunk/include/llvm/Analysis/GlobalsModRef.h Fri Aug 14 03:39:32 2015<br>
@@ -98,10 +98,6 @@ public:<br>
                     const MemoryLocation &LocB) override;<br>
   ModRefInfo getModRefInfo(ImmutableCallSite CS,<br>
                            const MemoryLocation &Loc) override;<br>
-  ModRefInfo getModRefInfo(ImmutableCallSite CS1,<br>
-                           ImmutableCallSite CS2) override {<br>
-    return AliasAnalysis::getModRefInfo(CS1, CS2);<br>
-  }<br>
<br>
   /// getModRefBehavior - Return the behavior of the specified function if<br>
   /// called from the specified call site.  The call site may be null in which<br>
<br>
Modified: llvm/trunk/include/llvm/Analysis/LibCallAliasAnalysis.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Analysis/LibCallAliasAnalysis.h?rev=245034&r1=245033&r2=245034&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Analysis/LibCallAliasAnalysis.h?rev=245034&r1=245033&r2=245034&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/include/llvm/Analysis/LibCallAliasAnalysis.h (original)<br>
+++ llvm/trunk/include/llvm/Analysis/LibCallAliasAnalysis.h Fri Aug 14 03:39:32 2015<br>
@@ -42,12 +42,6 @@ struct LibCallAliasAnalysis : public Fun<br>
   ModRefInfo getModRefInfo(ImmutableCallSite CS,<br>
                            const MemoryLocation &Loc) override;<br>
<br>
-  ModRefInfo getModRefInfo(ImmutableCallSite CS1,<br>
-                           ImmutableCallSite CS2) override {<br>
-    // TODO: Could compare two direct calls against each other if we cared to.<br>
-    return AliasAnalysis::getModRefInfo(CS1, CS2);<br>
-  }<br>
-<br>
   void getAnalysisUsage(AnalysisUsage &AU) const override;<br>
<br>
   bool runOnFunction(Function &F) override;<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div></div></div></blockquote></div>