<div dir="ltr">Hm, I did misblame it. Still, the build with your fix has the test failures that we see at head:<div><a href="http://lab.llvm.org:8011/builders/sanitizer-windows/builds/8278">http://lab.llvm.org:8011/builders/sanitizer-windows/builds/8278</a></div><div><br></div><div>The changes since then are Chandler's alias analysis stuff, which could be related but is unlikely.</div><div><br></div><div>Anyway, I'll look into it tomorrow.</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Aug 12, 2015 at 6:16 PM, Rafael Espíndola <span dir="ltr"><<a href="mailto:rafael.espindola@gmail.com" target="_blank">rafael.espindola@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">It is now linking:<br>
<br>
<a href="http://lab.llvm.org:8011/builders/sanitizer-windows/builds/8313/steps/run%20tests/logs/stdio" rel="noreferrer" target="_blank">http://lab.llvm.org:8011/builders/sanitizer-windows/builds/8313/steps/run%20tests/logs/stdio</a><br>
<br>
Kostya, was there any semantic value in the function being marked always_inline?<br>
<div class="HOEnZb"><div class="h5"><br>
<br>
On 12 August 2015 at 20:22, Reid Kleckner <<a href="mailto:rnk@google.com">rnk@google.com</a>> wrote:<br>
> This broke the winasan tests:<br>
> <a href="http://lab.llvm.org:8011/builders/sanitizer-windows/builds/8274" rel="noreferrer" target="_blank">http://lab.llvm.org:8011/builders/sanitizer-windows/builds/8274</a><br>
><br>
> The alwaysinline tweak didn't seem to fix it.<br>
><br>
> On Wed, Aug 12, 2015 at 10:09 AM, Rafael Espindola via llvm-commits<br>
> <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br>
>><br>
>> Author: rafael<br>
>> Date: Wed Aug 12 12:09:25 2015<br>
>> New Revision: 244767<br>
>><br>
>> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=244767&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=244767&view=rev</a><br>
>> Log:<br>
>> Use /Zc:inline when building with MSVC.<br>
>><br>
>> This reduces the total .obj size when building llvm from<br>
>> 496,690,342 to 219,334,936 bytes.<br>
>><br>
>> Modified:<br>
>>     llvm/trunk/cmake/modules/HandleLLVMOptions.cmake<br>
>><br>
>> Modified: llvm/trunk/cmake/modules/HandleLLVMOptions.cmake<br>
>> URL:<br>
>> <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/cmake/modules/HandleLLVMOptions.cmake?rev=244767&r1=244766&r2=244767&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/cmake/modules/HandleLLVMOptions.cmake?rev=244767&r1=244766&r2=244767&view=diff</a><br>
>><br>
>> ==============================================================================<br>
>> --- llvm/trunk/cmake/modules/HandleLLVMOptions.cmake (original)<br>
>> +++ llvm/trunk/cmake/modules/HandleLLVMOptions.cmake Wed Aug 12 12:09:25<br>
>> 2015<br>
>> @@ -348,6 +348,8 @@ if( MSVC )<br>
>>      append("${flag}" CMAKE_C_FLAGS CMAKE_CXX_FLAGS)<br>
>>    endforeach(flag)<br>
>><br>
>> +  append("/Zc:inline" CMAKE_C_FLAGS CMAKE_CXX_FLAGS)<br>
>> +<br>
>>    # Disable sized deallocation if the flag is supported. MSVC fails to<br>
>> compile<br>
>>    # the operator new overload in User otherwise.<br>
>>    check_c_compiler_flag("/WX /Zc:sizedDealloc-" SUPPORTS_SIZED_DEALLOC)<br>
>><br>
>><br>
>> _______________________________________________<br>
>> llvm-commits mailing list<br>
>> <a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
>> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
><br>
><br>
</div></div></blockquote></div><br></div>