<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Samsonov, ping?<div class=""><br class=""></div><div class="">-Chris</div><div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Aug 10, 2015, at 2:56 PM, Chris Bieneman via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><blockquote type="cite" class=""><div class=""><br class="Apple-interchange-newline">On Aug 10, 2015, at 1:50 PM, Justin Bogner <<a href="mailto:mail@justinbogner.com" class="">mail@justinbogner.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><br class="" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><span class="" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;">Chris Bieneman <</span><a href="mailto:beanz@apple.com" class="" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;">beanz@apple.com</a><span class="" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;">> writes:</span><br class="" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><blockquote type="cite" class="" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;">beanz added a comment.<br class=""><br class="">I'll send updated patches shortly. Comments inline below.<br class=""><br class=""><br class="">================<br class="">Comment at: cmake/Modules/CompilerRTDarwinUtils.cmake:31<br class="">@@ +30,3 @@<br class="">+<br class="">+ string(REGEX MATCH "configured to support archs: (.*)\nLTO support.*"<br class="">+ ARCHES_MATCHED "${LINKER_VERSION}")<br class="">----------------<br class="">filcab wrote:<br class=""><blockquote type="cite" class="">Nit: Do we care about having the "LTO support" string?<br class=""></blockquote>The "LTO Support" string is needed to escape the end of the<br class="">regex. Since .* matches everything and nothing, and the behavior is to<br class="">match as much as possible without the "LTO Support" string it matches<br class="">the whole rest of the output.<br class=""><br class="">I'm no regex expert though, so if you have a better suggestion I'm open.<br class=""></blockquote><br class="" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><span class="" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;">Presumably "configured to support archs: ([^\n]*)\n" would do what you want.</span><br class="" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"></div></blockquote><div class=""><br class=""></div><div class="">This is almost exactly what Fil suggested in IRC, and I updated the patches already :-)</div><div class=""><br class=""></div><div class="">-Chris</div><br class=""><blockquote type="cite" class=""><div class=""><br class="" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><blockquote type="cite" class="" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><br class="">================<br class="">Comment at: cmake/Modules/CompilerRTDarwinUtils.cmake:63<br class="">@@ +62,3 @@<br class="">+ list(REMOVE_ITEM archs "x86_64h")<br class="">+ endif()<br class="">+<br class="">----------------<br class="">filcab wrote:<br class=""><blockquote type="cite" class="">"will build", but then you remove that arch?<br class="">Why is the `iossim` different from OS X, here?<br class=""></blockquote>I should explain better. The trivial test program does compile for<br class="">x86_64h because it falls back to using the x86_64 libraries, but<br class="">x86_64h isn't actually a valid simulator architecture, so other things<br class="">will fail. I've had trouble finding a non-hacky way to make that<br class="">detection work.<br class=""><br class="">================<br class="">Comment at: cmake/config-ix.cmake:318<br class="">@@ +317,3 @@<br class="">+ <br class="">+ if(NOT MACOSX_VERSION_MIN_FLAG)<br class="">+ darwin_test_archs(osx<br class="">----------------<br class="">filcab wrote:<br class=""><blockquote type="cite" class="">What's the behavior you want if `MACOSX_VERSION_MIN_FLAG` is set?<br class="">I'm guessing you're going with "just assume the user just wants OS<br class="">X, since they passed that flag in the CXX flags".<br class="">Shouldn't we at least test the OS X archs?<br class=""><br class="">Why are we skipping iOS and iOS Simulator when we have a specific<br class="">minimum OS X version? (I'm good with "so we don't change the user's<br class="">CXX flags", but want to double-check)<br class=""></blockquote>The behavior if the user set macos-version-min explicitly is kinda<br class="">complicated and probably broken. As it is now, I'm pretty sure we just<br class="">don't build the sanitizers if you specify an explicit version min.<br class=""><br class="">The rationale for skipping iOS and the simulator I assume is because<br class="">we don't want to change the user's CXX flags, and there may be other<br class="">incompatibilities. I don't know for sure though because that code<br class="">exists in-tree today. This patch just moves it from the root<br class="">CMakeLists.txt to config-ix as per samsonov's comments on previous<br class="">reviews.<br class=""><br class="">================<br class="">Comment at: cmake/config-ix.cmake:335<br class="">@@ +334,3 @@<br class="">+ ${DARWIN_COMMON_LINKFLAGS}<br class="">+ -Wl,-ios_simulator_version_min,7.0.0<br class="">+ -mios-simulator-version-min=7.0<br class="">----------------<br class="">filcab wrote:<br class=""><blockquote type="cite" class="">Does clang not pass the proper flag to the linker for the iOS<br class="">Simulator (when the flag below is passed)?<br class="">If not, are they both needed, still? Since clang should only be<br class="">invoking the linker.<br class="">Why didn't we need this for OS X? Why are the versions slightly different?<br class=""></blockquote>You're right. Since the driver should be passing this through we don't<br class="">need it explicitly set.<br class=""><br class=""><br class=""><a href="http://reviews.llvm.org/D11820" class="">http://reviews.llvm.org/D11820</a></blockquote></div></blockquote></div><br class="" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">_______________________________________________</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">llvm-commits mailing list</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><a href="mailto:llvm-commits@lists.llvm.org" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">llvm-commits@lists.llvm.org</a><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a></div></blockquote></div><br class=""></div></body></html>