<div dir="ltr">Isn't AddLLVM.cmake (along with all of llvm/cmake/modules) copied into the LLVM install directory? Or does the compiler-rt standalone build simply not depend on LLVM?</div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Aug 11, 2015 at 11:15 AM, Chris Bieneman <span dir="ltr"><<a href="mailto:beanz@apple.com" target="_blank">beanz@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">This breaks standalone compiler-rt builds because it adds a dependency on AddLLVM.cmake which isn’t relied on anywhere else.<br>
<br>
We should consider doing this differently since the plans for compiler-rt's CMake rely on standalone builds working.<br>
<span class="HOEnZb"><font color="#888888"><br>
-Chris<br>
</font></span><div class="HOEnZb"><div class="h5"><br>
> On Aug 11, 2015, at 10:18 AM, Reid Kleckner via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br>
><br>
> Author: rnk<br>
> Date: Tue Aug 11 12:18:23 2015<br>
> New Revision: 244634<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=244634&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=244634&view=rev</a><br>
> Log:<br>
> [cmake] Handle external source for lld and libcxx<br>
><br>
> As requested in post-commit review of r244549.<br>
><br>
> Modified:<br>
>    compiler-rt/trunk/CMakeLists.txt<br>
><br>
> Modified: compiler-rt/trunk/CMakeLists.txt<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/CMakeLists.txt?rev=244634&r1=244633&r2=244634&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/CMakeLists.txt?rev=244634&r1=244633&r2=244634&view=diff</a><br>
> ==============================================================================<br>
> --- compiler-rt/trunk/CMakeLists.txt (original)<br>
> +++ compiler-rt/trunk/CMakeLists.txt Tue Aug 11 12:18:23 2015<br>
> @@ -348,14 +348,14 @@ pythonize_bool(SANITIZER_CAN_USE_CXXABI)<br>
><br>
> add_subdirectory(include)<br>
><br>
> -set(COMPILER_RT_LIBCXX_PATH ${LLVM_MAIN_SRC_DIR}/projects/libcxx)<br>
> +find_llvm_external_project(projects libcxx COMPILER_RT_LIBCXX_PATH)<br>
> if(EXISTS ${COMPILER_RT_LIBCXX_PATH}/)<br>
>   set(COMPILER_RT_HAS_LIBCXX_SOURCES TRUE)<br>
> else()<br>
>   set(COMPILER_RT_HAS_LIBCXX_SOURCES FALSE)<br>
> endif()<br>
><br>
> -set(COMPILER_RT_LLD_PATH ${LLVM_MAIN_SRC_DIR}/tools/lld)<br>
> +find_llvm_external_project(projects libcxx COMPILER_RT_LLD_PATH)<br>
> if(EXISTS ${COMPILER_RT_LLD_PATH}/)<br>
>   set(COMPILER_RT_HAS_LLD_SOURCES TRUE)<br>
> else()<br>
><br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
<br>
</div></div></blockquote></div><br></div>