<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">As it is today, compiler-rt does not depend on LLVM, and there is no include for AddLLVM. I don’t think we should change that because I believe we still support compiler-rt being used with GCC.<div class=""><br class=""></div><div class="">-Chris</div><div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Aug 11, 2015, at 11:25 AM, Reid Kleckner <<a href="mailto:rnk@google.com" class="">rnk@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">Isn't AddLLVM.cmake (along with all of llvm/cmake/modules) copied into the LLVM install directory? Or does the compiler-rt standalone build simply not depend on LLVM?</div><div class="gmail_extra"><br class=""><div class="gmail_quote">On Tue, Aug 11, 2015 at 11:15 AM, Chris Bieneman <span dir="ltr" class=""><<a href="mailto:beanz@apple.com" target="_blank" class="">beanz@apple.com</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">This breaks standalone compiler-rt builds because it adds a dependency on AddLLVM.cmake which isn’t relied on anywhere else.<br class="">
<br class="">
We should consider doing this differently since the plans for compiler-rt's CMake rely on standalone builds working.<br class="">
<span class="HOEnZb"><font color="#888888" class=""><br class="">
-Chris<br class="">
</font></span><div class="HOEnZb"><div class="h5"><br class="">
> On Aug 11, 2015, at 10:18 AM, Reid Kleckner via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a>> wrote:<br class="">
><br class="">
> Author: rnk<br class="">
> Date: Tue Aug 11 12:18:23 2015<br class="">
> New Revision: 244634<br class="">
><br class="">
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=244634&view=rev" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-project?rev=244634&view=rev</a><br class="">
> Log:<br class="">
> [cmake] Handle external source for lld and libcxx<br class="">
><br class="">
> As requested in post-commit review of r244549.<br class="">
><br class="">
> Modified:<br class="">
> compiler-rt/trunk/CMakeLists.txt<br class="">
><br class="">
> Modified: compiler-rt/trunk/CMakeLists.txt<br class="">
> URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/CMakeLists.txt?rev=244634&r1=244633&r2=244634&view=diff" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/CMakeLists.txt?rev=244634&r1=244633&r2=244634&view=diff</a><br class="">
> ==============================================================================<br class="">
> --- compiler-rt/trunk/CMakeLists.txt (original)<br class="">
> +++ compiler-rt/trunk/CMakeLists.txt Tue Aug 11 12:18:23 2015<br class="">
> @@ -348,14 +348,14 @@ pythonize_bool(SANITIZER_CAN_USE_CXXABI)<br class="">
><br class="">
> add_subdirectory(include)<br class="">
><br class="">
> -set(COMPILER_RT_LIBCXX_PATH ${LLVM_MAIN_SRC_DIR}/projects/libcxx)<br class="">
> +find_llvm_external_project(projects libcxx COMPILER_RT_LIBCXX_PATH)<br class="">
> if(EXISTS ${COMPILER_RT_LIBCXX_PATH}/)<br class="">
> set(COMPILER_RT_HAS_LIBCXX_SOURCES TRUE)<br class="">
> else()<br class="">
> set(COMPILER_RT_HAS_LIBCXX_SOURCES FALSE)<br class="">
> endif()<br class="">
><br class="">
> -set(COMPILER_RT_LLD_PATH ${LLVM_MAIN_SRC_DIR}/tools/lld)<br class="">
> +find_llvm_external_project(projects libcxx COMPILER_RT_LLD_PATH)<br class="">
> if(EXISTS ${COMPILER_RT_LLD_PATH}/)<br class="">
> set(COMPILER_RT_HAS_LLD_SOURCES TRUE)<br class="">
> else()<br class="">
><br class="">
><br class="">
> _______________________________________________<br class="">
> llvm-commits mailing list<br class="">
> <a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a><br class="">
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank" class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br class="">
<br class="">
</div></div></blockquote></div><br class=""></div>
</div></blockquote></div><br class=""></div></body></html>