<p dir="ltr">Thanks! </p>
<div class="gmail_quote">On Aug 11, 2015 7:38 PM, "Rui Ueyama via llvm-commits" <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: ruiu<br>
Date: Tue Aug 11 18:37:25 2015<br>
New Revision: 244701<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=244701&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=244701&view=rev</a><br>
Log:<br>
ELF2: Make Defined{Regular,Weak} ctors look the same as other SymbolBody ctors.<br>
<br>
Modified:<br>
    lld/trunk/ELF/Symbols.cpp<br>
    lld/trunk/ELF/Symbols.h<br>
<br>
Modified: lld/trunk/ELF/Symbols.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Symbols.cpp?rev=244701&r1=244700&r2=244701&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Symbols.cpp?rev=244701&r1=244700&r2=244701&view=diff</a><br>
==============================================================================<br>
--- lld/trunk/ELF/Symbols.cpp (original)<br>
+++ lld/trunk/ELF/Symbols.cpp Tue Aug 11 18:37:25 2015<br>
@@ -17,11 +17,6 @@ using namespace llvm::object;<br>
 using namespace lld;<br>
 using namespace lld::elf2;<br>
<br>
-DefinedRegular::DefinedRegular(StringRef Name)<br>
-    : Defined(DefinedRegularKind, Name) {}<br>
-<br>
-DefinedWeak::DefinedWeak(StringRef Name) : Defined(DefinedWeakKind, Name) {}<br>
-<br>
 // Returns 1, 0 or -1 if this symbol should take precedence<br>
 // over the Other, tie or lose, respectively.<br>
 int SymbolBody::compare(SymbolBody *Other) {<br>
<br>
Modified: lld/trunk/ELF/Symbols.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Symbols.h?rev=244701&r1=244700&r2=244701&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Symbols.h?rev=244701&r1=244700&r2=244701&view=diff</a><br>
==============================================================================<br>
--- lld/trunk/ELF/Symbols.h (original)<br>
+++ lld/trunk/ELF/Symbols.h Tue Aug 11 18:37:25 2015<br>
@@ -76,7 +76,7 @@ protected:<br>
 // etc.<br>
 class Defined : public SymbolBody {<br>
 public:<br>
-  Defined(Kind K, StringRef N = "") : SymbolBody(K, N) {}<br>
+  explicit Defined(Kind K, StringRef N = "") : SymbolBody(K, N) {}<br>
<br>
   static bool classof(const SymbolBody *S) {<br>
     Kind K = S->kind();<br>
@@ -87,7 +87,7 @@ public:<br>
 // Regular defined symbols read from object file symbol tables.<br>
 class DefinedRegular : public Defined {<br>
 public:<br>
-  DefinedRegular(StringRef Name);<br>
+  explicit DefinedRegular(StringRef N) : Defined(DefinedRegularKind, N) {}<br>
<br>
   static bool classof(const SymbolBody *S) {<br>
     return S->kind() == DefinedRegularKind;<br>
@@ -96,7 +96,7 @@ public:<br>
<br>
 class DefinedWeak : public Defined {<br>
 public:<br>
-  DefinedWeak(StringRef Name);<br>
+  explicit DefinedWeak(StringRef N) : Defined(DefinedWeakKind, N) {}<br>
<br>
   static bool classof(const SymbolBody *S) {<br>
     return S->kind() == DefinedWeakKind;<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>