<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Aug 6, 2015 at 4:24 PM, Frédéric Riss <span dir="ltr"><<a href="mailto:friss@apple.com" target="_blank">friss@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><br><div><span class=""><blockquote type="cite"><div>On Aug 6, 2015, at 3:54 PM, David Blaikie <<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>> wrote:</div><br><div><br><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><div class="gmail_quote" style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px">On Thu, Aug 6, 2015 at 3:50 PM, Frédéric Riss<span> </span><span dir="ltr"><<a href="mailto:friss@apple.com" target="_blank">friss@apple.com</a>></span><span> </span>wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div style="word-wrap:break-word"><br><div><span><blockquote type="cite"><div>On Aug 6, 2015, at 3:21 PM, David Blaikie <<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>> wrote:</div><br><div><div dir="ltr">No need for "LTParams(), " in the MCAssembler ctor, is there?<br></div></div></blockquote><div><br></div></span><div>'course not.</div><span><br><blockquote type="cite"><div><div dir="ltr">Is the '+' needed here "+Params.DWARF2LineOpcodeBase - 1” ?<br></div></div></blockquote><div><br></div></span><div>:-) I must have copied over a failed hunk from a .rej file and then clang-format-diff stuck it to the expression.</div><span><br><blockquote type="cite"><div><div dir="ltr">There's some unrelated formatting changes (forceExpAbs?) that could be removed.<br><br>& I guess this has been run through clang-format?</div></div></blockquote><div><br></div></span><div>Hence the formatting changes. </div></div></div></blockquote><div><br></div><div>There's a handy script that just clang-formats things that have already been touched ("tools/clang/tools/clang-format/git-clang-format origin" is how I use it, then inspect the local changes & commit them if they look reasonable).</div></div></div></blockquote><div><br></div></span><div>Mmmh, I’ll try that. I currently use "git diff | tools/clang/tools/clang-format/clang-format-diff.py -i -p1”. I would have expected that to be equivalent.</div></div></div></blockquote><div><br>Could be? I wonder how it ended up reformatting that extra/unrelated signature?<br> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><div><span class=""><br><blockquote type="cite"><div><div class="gmail_quote" style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div style="word-wrap:break-word"><div><div>New patch attached.</div></div></div></blockquote><div><br></div><div>Looks good - please commit :)<br></div></div></div></blockquote><div><br></div></span>Thanks!<span class=""><br><blockquote type="cite"><div><div class="gmail_quote" style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><div><br>- Dave</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div style="word-wrap:break-word"><div><div><br></div><div></div></div></div><br><div style="word-wrap:break-word"><div><div></div><br><blockquote type="cite"><div><div class="gmail_extra"><div class="gmail_quote">On Thu, Aug 6, 2015 at 3:11 PM, Frédéric Riss<span> </span><span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span><span> </span>wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">Hi,<br><br>The attached patch (based on a patch from Adrian), allows to customize the encoding of the Dwarf line tables emitted by MC. llvm-dsymutil has be able to recreate line tables that were created by other compilers and that do not necessarily use the same settings. The patch is really mechanical just threading a new word-sized MCDwarfLineTableParams trust through he linetable routines. The patch is NFC wrt current uses.<br><br><br><br><br>Fred<span> </span><br>_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br><a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a></blockquote></div></div></div></blockquote></div></div></blockquote></div></div></blockquote></span></div><br></div></blockquote></div><br></div></div>