<div dir="ltr">Oh, the lit test is also affected: <div><pre style="font-family:'Courier New',courier,monotype,monospace;color:rgb(0,0,0);font-size:medium"><span class="stdout">/home/linaro/devel/buildbot/clang-cmake-thumbv7-a15-full-sh/stage1/./bin/clang -gline-tables-only -fsanitize=address -mcpu=cortex-a15 -mthumb /home/linaro/devel/buildbot/clang-cmake-thumbv7-a15-full-sh/llvm/projects/compiler-rt/test/sanitizer_common/TestCases/Linux/fpe.cc -o /home/linaro/devel/buildbot/clang-cmake-thumbv7-a15-full-sh/stage1/projects/compiler-rt/test/sanitizer_common/asan-arm-Linux/Linux/Output/fpe.cc.tmp
not /home/linaro/devel/buildbot/clang-cmake-thumbv7-a15-full-sh/stage1/projects/compiler-rt/test/sanitizer_common/asan-arm-Linux/Linux/Output/fpe.cc.tmp 2>&1 | FileCheck --check-prefix=CHECK1 /home/linaro/devel/buildbot/clang-cmake-thumbv7-a15-full-sh/llvm/projects/compiler-rt/test/sanitizer_common/TestCases/Linux/fpe.cc
ASAN_OPTIONS=handle_sigfpe=0 not --crash /home/linaro/devel/buildbot/clang-cmake-thumbv7-a15-full-sh/stage1/projects/compiler-rt/test/sanitizer_common/asan-arm-Linux/Linux/Output/fpe.cc.tmp 2>&1 | FileCheck --check-prefix=CHECK0 /home/linaro/devel/buildbot/clang-cmake-thumbv7-a15-full-sh/llvm/projects/compiler-rt/test/sanitizer_common/TestCases/Linux/fpe.cc
ASAN_OPTIONS=handle_sigfpe=1 not /home/linaro/devel/buildbot/clang-cmake-thumbv7-a15-full-sh/stage1/projects/compiler-rt/test/sanitizer_common/asan-arm-Linux/Linux/Output/fpe.cc.tmp 2>&1 | FileCheck --check-prefix=CHECK1 /home/linaro/devel/buildbot/clang-cmake-thumbv7-a15-full-sh/llvm/projects/compiler-rt/test/sanitizer_common/TestCases/Linux/fpe.cc
--
Exit Code: 2
Command Output (stderr):
--
FileCheck error: '-' is empty.
</span></pre></div><div><span class="stdout"><br></span></div><div><span class="stdout"><br></span></div><div><span class="stdout">Is sigfpe generated under different circumstances on ARM?</span></div>r244234 re-lands this patch w/o the redundant unit test bit (AddressSanitizer-Unit::AddressSanitizer.FPECrashTest)<div>and with "REQUIRES: x86_64-supported-target" in test/sanitizer_common/TestCases/Linux/fpe.cc</div><div><br></div><div>I am online for the rest of the day (PST) and watching the bots. <br><div><span class="stdout"><br></span></div></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Aug 6, 2015 at 10:27 AM, Kostya Serebryany <span dir="ltr"><<a href="mailto:kcc@google.com" target="_blank">kcc@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">+Karl, author of the patch. <div><br></div><div>Thanks for reverting and sorry for the breakage. </div><div>I don't have access to ARM myself, nor much experience with it. </div><div>Any ideas what might have gone wrong? </div><div><br></div>I am tempted to re-apply the patch w/o the AddressSanitizer.FPECrashTest test -- the same functionality <div>is also covered by a lit test which did not seem to fail on ARM. WDYT? </div><div><br></div></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Aug 6, 2015 at 5:43 AM, Renato Golin <span dir="ltr"><<a href="mailto:renato.golin@linaro.org" target="_blank">renato.golin@linaro.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Sorry, reverted in r244210, we should investigate what's wrong offline.<br>
<br>
cheers,<br>
--renato<br>
<div><div><br>
On 6 August 2015 at 10:04, Renato Golin <<a href="mailto:renato.golin@linaro.org" target="_blank">renato.golin@linaro.org</a>> wrote:<br>
> On 5 August 2015 at 22:19, Kostya Serebryany <<a href="mailto:kcc@google.com" target="_blank">kcc@google.com</a>> wrote:<br>
>> Author: kcc<br>
>> Date: Wed Aug 5 16:19:11 2015<br>
>> New Revision: 244136<br>
>><br>
>> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=244136&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=244136&view=rev</a><br>
>> Log:<br>
>> [sanitizer] Add the flag handle_sigfpe that is default true to handle SIGFPE crashes same as SIGSEV crashes, patch by Karl Skomski<br>
><br>
> Hi Kostya,<br>
><br>
> It seems this commit broke our ARM bots:<br>
><br>
> <a href="http://lab.llvm.org:8011/builders/clang-cmake-armv7-a15-full/builds/6917" rel="noreferrer" target="_blank">http://lab.llvm.org:8011/builders/clang-cmake-armv7-a15-full/builds/6917</a><br>
><br>
> <a href="http://lab.llvm.org:8011/builders/clang-cmake-thumbv7-a15-full-sh/builds/1885" rel="noreferrer" target="_blank">http://lab.llvm.org:8011/builders/clang-cmake-thumbv7-a15-full-sh/builds/1885</a><br>
><br>
> You haven't been warned because there were other failures in there,<br>
> that are now gone.<br>
><br>
> cheers,<br>
> --renato<br>
</div></div></blockquote></div><br></div>
</div></div></blockquote></div><br></div>