<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Jul 31, 2015, at 9:48 AM, Puyan Lotfi <<a href="mailto:puyan@puyan.org" class="">puyan@puyan.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class=""><br class=""><div class="gmail_extra"><br class=""><div class="gmail_quote">On Fri, Jul 31, 2015 at 9:44 AM, Krzysztof Parzyszek <span dir="ltr" class=""><<a href="mailto:kparzysz@codeaurora.org" target="_blank" class="">kparzysz@codeaurora.org</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On 7/31/2015 8:27 AM, Aaron Ballman wrote:<br class="">
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br class="">
I am wondering why this should be an ADT instead of one-off<br class="">
functionality. I see that you're going to use it for<br class="">
MachineBasicBlock, but are there other use cases as well? The kind of<br class="">
functionality that this class provides is covered by basic STL<br class="">
mechanisms, and so I am hesitant to support it as an ADT for all of<br class="">
our users unless this is something we expect will be heavily used (or<br class="">
is heavily customized to support toolchain needs).<br class="">
</blockquote>
<br class=""></span>
I agree. Also, I think we should avoid creating new ADT unless there is a compelling reason to have our own implementation of a container.<span class="HOEnZb"><font color="#888888" class=""><br class="">
<br class=""></font></span></blockquote><div class=""><br class=""></div><div class="">Does this mean we should also try to remove any existing ADTs that aren't as compelling to have anymore?</div></div></div></div></div></blockquote><div><br class=""></div><div>Do you have an example in mind?</div><div><br class=""></div><div>— </div><div>Mehdi</div><div><br class=""></div><div><br class=""></div><br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""><div class="gmail_extra"><div class="gmail_quote"><div class=""> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="HOEnZb"><font color="#888888" class="">
-Krzysztof<br class="">
<br class="">
-- <br class="">
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation</font></span><div class="HOEnZb"><div class="h5"><br class="">
_______________________________________________<br class="">
llvm-commits mailing list<br class="">
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank" class="">llvm-commits@cs.uiuc.edu</a><br class="">
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank" class="">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br class="">
</div></div></blockquote></div><br class=""></div></div>
_______________________________________________<br class="">llvm-commits mailing list<br class=""><a href="mailto:llvm-commits@cs.uiuc.edu" class="">llvm-commits@cs.uiuc.edu</a><br class="">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits<br class=""></div></blockquote></div><br class=""></body></html>