<div dir="ltr">Hey Duncan - what's this "extraData" field intended for? Is this a reasonable use of it?<br><br>I imagine we just want to extend the schema here to explicitly include address space?<br><br>Could we instead extract it from the value we're describing? (probably not? if the address happens to be a constant or something (which I guess is more likely in custom address spaces) it wouldn't be carrying explicit address space info?)</div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Jul 30, 2015 at 12:33 AM, Matt Arsenault <span dir="ltr"><<a href="mailto:Matthew.Arsenault@amd.com" target="_blank">Matthew.Arsenault@amd.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">arsenm created this revision.<br>
arsenm added a reviewer: echristo.<br>
arsenm added a subscriber: llvm-commits.<br>
<br>
<a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_D11635&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=LtQOQKSfhmafHkOFHfVHnxsW3OZtjhBMnzmNmxJfyC4&s=pBQXbkhcmueJ9KXfJnCorOzWRA8Fe-431MSilwRt5fo&e=" rel="noreferrer" target="_blank">http://reviews.llvm.org/D11635</a><br>
<br>
Files:<br>
  include/llvm/IR/DIBuilder.h<br>
  include/llvm/IR/DebugInfoMetadata.h<br>
  lib/CodeGen/AsmPrinter/DwarfUnit.cpp<br>
  lib/IR/DIBuilder.cpp<br>
  test/DebugInfo/AMDGPU/DW_AT_address_class.ll<br>
  test/DebugInfo/AMDGPU/lit.local.cfg<br>
<br>
<br>_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
<br></blockquote></div><br></div>