<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Jul 28, 2015, at 9:59 AM, David Blaikie <<a href="mailto:dblaikie@gmail.com" class="">dblaikie@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">I'm OK calling it 'reverse' as you have (since it has just the one argument it shouldn't be ambiguous with the iterator versions)<br class=""><br class="">* These functions shouldn't be ‘static’</div></div></blockquote>Good point. Made them inline like the other methods in the same file.<br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" class="">* Could you try using non-member begin/end in the second version - that should allow it to work with arrays. Give it a go/add a test?<br class=""></div></div></blockquote>Done. Added a test for this too.<br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" class="">* Maybe test the case where a container has rbegin/rend and begin/end to ensure we still favor the rbegin/rend (and that it's not ambiguous?) - presumably they're more efficient, if they're provided?<br class=""></div></div></blockquote>Added a test for this too. I left begin(), end() without method bodies so that if they were called we’d get linker errors.<br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""><br class="">& the reason you don't need explicit SFINAE is because you put the interesting expressions in the return type - so they're part of the SFINAE condition already, conveniently.<br class=""></div></div></blockquote>Makes sense. Thanks for the explanation.<br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""><br class="">I think Saleem (cc'd) had an existing implementation of something like this that he might be willing to provide some insight from?<br class=""></div></div></blockquote>Cool. Happy to see his implementation too, and to take whichever suits.</div><div><br class=""></div><div>Updated patch included.</div><div><br class=""></div><div>Cheers,</div><div>Pete</div><div><br class=""></div><div></div></body></html>