<div dir="ltr">wow! <div>Did you run tsan under ubsan? </div></div><div class="gmail_extra"><br><div class="gmail_quote">On Sun, Jul 26, 2015 at 12:45 AM, Dmitry Vyukov <span dir="ltr"><<a href="mailto:dvyukov@google.com" target="_blank">dvyukov@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: dvyukov<br>
Date: Sun Jul 26 02:45:26 2015<br>
New Revision: 243241<br>
<br>
URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject-3Frev-3D243241-26view-3Drev&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=z8vWZwoDzT_h3Vh-OUCF2c67tQxl5V5PYrnSDgIylNU&s=9N3VmWheWe24WMcdWXj_DhYPZkZZk3H9T3Gz8Hsssx4&e=" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=243241&view=rev</a><br>
Log:<br>
tsan: fix shift overflow<br>
<br>
3<<30 fits into 32-bit unsigned, but does not fit into int.<br>
Found by ubsan.<br>
<br>
<br>
Modified:<br>
    compiler-rt/trunk/lib/tsan/rtl/tsan_sync.h<br>
<br>
Modified: compiler-rt/trunk/lib/tsan/rtl/tsan_sync.h<br>
URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_compiler-2Drt_trunk_lib_tsan_rtl_tsan-5Fsync.h-3Frev-3D243241-26r1-3D243240-26r2-3D243241-26view-3Ddiff&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=z8vWZwoDzT_h3Vh-OUCF2c67tQxl5V5PYrnSDgIylNU&s=iFR08GJI96vI_Y5YuDOnq5FI8LD6eB8SrFsSviKEO68&e=" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/tsan/rtl/tsan_sync.h?rev=243241&r1=243240&r2=243241&view=diff</a><br>
==============================================================================<br>
--- compiler-rt/trunk/lib/tsan/rtl/tsan_sync.h (original)<br>
+++ compiler-rt/trunk/lib/tsan/rtl/tsan_sync.h Sun Jul 26 02:45:26 2015<br>
@@ -86,9 +86,9 @@ class MetaMap {<br>
   void OnThreadIdle(ThreadState *thr);<br>
<br>
  private:<br>
-  static const u32 kFlagMask  = 3 << 30;<br>
-  static const u32 kFlagBlock = 1 << 30;<br>
-  static const u32 kFlagSync  = 2 << 30;<br>
+  static const u32 kFlagMask  = 3u << 30;<br>
+  static const u32 kFlagBlock = 1u << 30;<br>
+  static const u32 kFlagSync  = 2u << 30;<br>
   typedef DenseSlabAlloc<MBlock, 1<<16, 1<<12> BlockAlloc;<br>
   typedef DenseSlabAlloc<SyncVar, 1<<16, 1<<10> SyncAlloc;<br>
   BlockAlloc block_alloc_;<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>