<div dir="ltr">ah, makes more sense. <div>I don't think we currently can run one sanitizer under another one, sadly. </div></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Jul 27, 2015 at 1:00 PM, Dmitry Vyukov <span dir="ltr"><<a href="mailto:dvyukov@google.com" target="_blank">dvyukov@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">I miserably failed to acknowledge the right tool. I did not run it<br>
under ubsan. It is a new gcc warning that caught it:<br>
<a href="https://urldefense.proofpoint.com/v2/url?u=https-3A__gcc.gnu.org_bugzilla_show-5Fbug.cgi-3Fid-3D67009&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=BOwH3KTNmcrAsx87LscX-iuCk8lI3WzBPPs3SkMdnKw&s=rzEm2C-Hqp50pMFfHAV_gcqD3JXie10Dec_3X_WKpVE&e=" rel="noreferrer" target="_blank">https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67009</a><br>
<span class=""><br>
<br>
<br>
<br>
On Mon, Jul 27, 2015 at 9:43 PM, Kostya Serebryany <<a href="mailto:kcc@google.com">kcc@google.com</a>> wrote:<br>
> wow!<br>
> Did you run tsan under ubsan?<br>
><br>
</span><span class="">> On Sun, Jul 26, 2015 at 12:45 AM, Dmitry Vyukov <<a href="mailto:dvyukov@google.com">dvyukov@google.com</a>> wrote:<br>
>><br>
>> Author: dvyukov<br>
>> Date: Sun Jul 26 02:45:26 2015<br>
>> New Revision: 243241<br>
>><br>
>> URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject-3Frev-3D243241-26view-3Drev&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=BOwH3KTNmcrAsx87LscX-iuCk8lI3WzBPPs3SkMdnKw&s=r1HXuiRP7_bFFbFa2xrs1l_4sb3mMm52STH51oPMQUE&e=" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=243241&view=rev</a><br>
</span><span class="">>> Log:<br>
>> tsan: fix shift overflow<br>
>><br>
>> 3<<30 fits into 32-bit unsigned, but does not fit into int.<br>
>> Found by ubsan.<br>
>><br>
>><br>
>> Modified:<br>
>>     compiler-rt/trunk/lib/tsan/rtl/tsan_sync.h<br>
>><br>
>> Modified: compiler-rt/trunk/lib/tsan/rtl/tsan_sync.h<br>
>> URL:<br>
>> <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_compiler-2Drt_trunk_lib_tsan_rtl_tsan-5Fsync.h-3Frev-3D243241-26r1-3D243240-26r2-3D243241-26view-3Ddiff&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=BOwH3KTNmcrAsx87LscX-iuCk8lI3WzBPPs3SkMdnKw&s=2u8FeFn9bB3iyvVb-wZe3hTAckuJfRtIbF8XzjrLoNI&e=" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/tsan/rtl/tsan_sync.h?rev=243241&r1=243240&r2=243241&view=diff</a><br>
>><br>
</span><span class="">>> ==============================================================================<br>
>> --- compiler-rt/trunk/lib/tsan/rtl/tsan_sync.h (original)<br>
>> +++ compiler-rt/trunk/lib/tsan/rtl/tsan_sync.h Sun Jul 26 02:45:26 2015<br>
>> @@ -86,9 +86,9 @@ class MetaMap {<br>
>>    void OnThreadIdle(ThreadState *thr);<br>
>><br>
>>   private:<br>
>> -  static const u32 kFlagMask  = 3 << 30;<br>
>> -  static const u32 kFlagBlock = 1 << 30;<br>
>> -  static const u32 kFlagSync  = 2 << 30;<br>
>> +  static const u32 kFlagMask  = 3u << 30;<br>
>> +  static const u32 kFlagBlock = 1u << 30;<br>
>> +  static const u32 kFlagSync  = 2u << 30;<br>
>>    typedef DenseSlabAlloc<MBlock, 1<<16, 1<<12> BlockAlloc;<br>
>>    typedef DenseSlabAlloc<SyncVar, 1<<16, 1<<10> SyncAlloc;<br>
>>    BlockAlloc block_alloc_;<br>
>><br>
>><br>
>> _______________________________________________<br>
>> llvm-commits mailing list<br>
</span>>> <a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
>> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
><br>
><br>
</blockquote></div><br></div>