<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Jul 22, 2015 at 11:53 PM, Erik de Castro Lopo <span dir="ltr"><<a href="mailto:mle+cl@mega-nerd.com" target="_blank">mle+cl@mega-nerd.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi,<br>
<br>
Two GettingStarted.rst patches attached.<br>
<br>
* Explain what compiler-rt does and why it may be needed.<br>
* Add libcxx and libcxxabi to the build.<br></blockquote><div><br></div><div>Taking a second and closer look at this:</div><div><br></div><div>Are libcxx and libcxxabi actually needed to use the sanitizers? Surely at least ubsan is fine without them. Could you update this to have a list of sanitizers that need those libraries?</div><div><br></div><div>-- Sean Silva</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Patches were validated using `make -f Makefile.sphinx` as suggested<br>
by @bogner on IRC.<br>
<br>
Cheers,<br>
Erik<br>
<span class="HOEnZb"><font color="#888888">--<br>
----------------------------------------------------------------------<br>
Erik de Castro Lopo<br>
<a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__www.mega-2Dnerd.com_&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=Goo9hIgqVJIYUtRwIakB-60YkTSQR6aDfPp7mwX_NUQ&s=826a5wmJBBXBn1Pf9Zoaatlyj26I9gFyLVObS1mEOx4&e=" rel="noreferrer" target="_blank">http://www.mega-nerd.com/</a><br>
</font></span><br>_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
<br></blockquote></div><br></div></div>