
<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Hi Hal, Gerolf,<div class=""><br class=""></div><div class="">Can I get a review on <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_D10714&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=PoqZDZL4dL7jpm0TwtTDCe3YhzCC8H6YJRtDgh3jXzI&s=xbWUqkckpTUaZTpxNk2OQa7j4mn-35wZkiCE1SQ9YlA&e=" class="">http://reviews.llvm.org/D10714</a>?. Do my comments meet your requirements?</div><div class=""><br class=""></div><div class="">Thanks,</div><div class=""><br class=""></div><div class="">Tyler</div><div class=""><br class=""></div><div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Jul 15, 2015, at 4:01 PM, Tyler Nowicki <<a href="mailto:tnowicki@apple.com" class="">tnowicki@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><meta http-equiv="Content-Type" content="text/html charset=utf-8" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class="">Committed in r241971.</div><div class=""><br class=""></div><div class="">Gerolf and Hal does the patch <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_D10714&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=PoqZDZL4dL7jpm0TwtTDCe3YhzCC8H6YJRtDgh3jXzI&s=xbWUqkckpTUaZTpxNk2OQa7j4mn-35wZkiCE1SQ9YlA&e=" class="">http://reviews.llvm.org/D10714</a> meet your quality requirements? Would you prefer to see some upfront work on the ‘already vectorized’ and ‘vectorize(disable)/vectorize_width(1)’ issues?</div><div class=""><br class=""></div><div class="">Thanks,</div><div class=""><br class=""></div><div class="">Tyler</div><br class=""><div class=""><blockquote type="cite" class=""><div class="">On Jul 9, 2015, at 6:56 PM, Hal Finkel <<a href="mailto:hfinkel@anl.gov" class="">hfinkel@anl.gov</a>> wrote:</div><br class="Apple-interchange-newline"><div class="">This 0002-Rename-some-uses-of-unroll-to-interleave.patch LGTM.<br class=""><br class=""> -Hal<br class=""><br class="">----- Original Message -----<br class=""><blockquote type="cite" class="">From: "Tyler Nowicki" <<a href="mailto:tnowicki@apple.com" class="">tnowicki@apple.com</a>><br class="">To: "Hal J. Finkel" <<a href="mailto:hfinkel@anl.gov" class="">hfinkel@anl.gov</a>><br class="">Cc: "Commit Messages and Patches for LLVM" <<a href="mailto:llvm-commits@cs.uiuc.edu" class="">llvm-commits@cs.uiuc.edu</a>>, "Gerolf Hoflehner" <<a href="mailto:ghoflehner@apple.com" class="">ghoflehner@apple.com</a>><br class="">Sent: Wednesday, June 24, 2015 6:23:45 PM<br class="">Subject: Re: [Patch][LoopVectorize] Renaming and Diagnostics for Loop Interleaving<br class=""><br class=""><br class="">Hi Hal,<br class=""><br class=""><br class="">Sorry about the 80 column limit. I put the main patch on phabricator,<br class="">sorry if you received some spam related to this. I am not very<br class="">familiar with it.<br class=""><br class=""><br class=""><a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_D10714&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=PoqZDZL4dL7jpm0TwtTDCe3YhzCC8H6YJRtDgh3jXzI&s=xbWUqkckpTUaZTpxNk2OQa7j4mn-35wZkiCE1SQ9YlA&e=" class="">http://reviews.llvm.org/D10714</a><br class=""><br class=""><br class="">Here is the renaming patch again with the column limit fixed.<br class=""><br class=""><br class="">Thanks,<br class=""><br class=""><br class="">Tyler<br class=""><br class=""><br class=""><br class=""><br class=""><br class=""><br class=""><br class=""><br class=""><br class=""><br class="">On Jun 22, 2015, at 5:18 PM, Hal Finkel < <a href="mailto:hfinkel@anl.gov" class="">hfinkel@anl.gov</a> > wrote:<br class=""><br class="">Hi Tyler,<br class=""><br class="">Please upload these patches to phabricator for review. I'd find that<br class="">much easier. Also, you have many lines in these patches that violate<br class="">the 80 column limit.<br class=""><br class="">Thanks again,<br class="">Hal<br class=""><br class="">----- Original Message -----<br class=""><br class=""><br class="">From: "Tyler Nowicki" < <a href="mailto:tnowicki@apple.com" class="">tnowicki@apple.com</a> ><br class="">To: <a href="mailto:llvm-commits@cs.uiuc.edu" class="">llvm-commits@cs.uiuc.edu</a><br class="">Sent: Monday, June 22, 2015 12:52:34 PM<br class="">Subject: Re: [Patch][LoopVectorize] Renaming and Diagnostics for Loop<br class="">Interleaving<br class=""><br class="">Hi,<br class=""><br class="">I would appreciate a review of these patches.<br class=""><br class="">Thanks,<br class=""><br class="">Tyler<br class=""><br class=""><br class=""><br class="">On Jun 15, 2015, at 6:30 PM, Tyler Nowicki < <a href="mailto:tnowicki@apple.com" class="">tnowicki@apple.com</a> ><br class="">wrote:<br class=""><br class="">Hi,<br class=""><br class="">Here is a renaming patch for names like unroll factor to names like<br class="">interleave count and a patch that improves the diagnostics for<br class="">interleaving so the user knows when they have explicitly disabled<br class="">interleaving and when it is not profitable. Includes test cases.<br class=""><br class="">Any comments are much appreciated!<br class=""><br class="">Tyler<br class=""><br class=""><0002-Rename-some-uses-of-unroll-to-interleave.patch><0003-Modify-diagnostic-messages-to-clearly-indicate-the-w.patch>_______________________________________________<br class="">llvm-commits mailing list<br class=""><a href="mailto:llvm-commits@cs.uiuc.edu" class="">llvm-commits@cs.uiuc.edu</a><br class="">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits<br class=""><br class=""><br class="">_______________________________________________<br class="">llvm-commits mailing list<br class="">llvm-commits@cs.uiuc.edu<br class="">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits<br class=""><br class=""><br class="">--<br class="">Hal Finkel<br class="">Assistant Computational Scientist<br class="">Leadership Computing Facility<br class="">Argonne National Laboratory<br class=""><br class=""><br class=""></blockquote><br class="">-- <br class="">Hal Finkel<br class="">Assistant Computational Scientist<br class="">Leadership Computing Facility<br class="">Argonne National Laboratory<br class=""></div></blockquote></div><br class=""></div></div></blockquote></div><br class=""></div></body></html>