<div dir="ltr">Thanks for the review, landed the early exit change first and now landing this!</div><br><div class="gmail_quote"><div dir="ltr">On Tue, Jul 21, 2015 at 4:50 PM Duncan P. N. Exon Smith <<a href="mailto:dexonsmith@apple.com">dexonsmith@apple.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
> On 2015-Jul-18, at 02:39, Chandler Carruth <<a href="mailto:chandlerc@gmail.com" target="_blank">chandlerc@gmail.com</a>> wrote:<br>
><br>
> chandlerc created this revision.<br>
> chandlerc added a subscriber: llvm-commits.<br>
> chandlerc added a dependency: D11324: [PM/AA] Replace the only use of the AliasAnalysis::deleteValue API (in GlobalsModRef) with CallbackVHs that trigger the same behavior..<br>
><br>
> Note that this will likely expose that we have dead arguments, members,<br>
> and maybe even pass requirements for AA. I'll be cleaning those up in<br>
> seperate patches. This just zaps the actual update API.<br>
><br>
> Depends on D11324.<br>
><br>
> <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_D11325&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=3pmJrp9kSyNKOBS_M3tJJfeqnoAV6Mu47f_FbdJ0Glw&s=pHe4vlHC7K2M5RAAy2dRy8_jLZqOW-3pa3BzxHr1a_k&e=" rel="noreferrer" target="_blank">http://reviews.llvm.org/D11325</a><br>
><br>
> Files:<br>
>  include/llvm/Analysis/AliasAnalysis.h<br>
>  lib/Analysis/AliasAnalysis.cpp<br>
>  lib/Analysis/AliasDebugger.cpp<br>
>  lib/Analysis/AliasSetTracker.cpp<br>
>  lib/Analysis/MemoryDependenceAnalysis.cpp<br>
>  lib/Analysis/NoAliasAnalysis.cpp<br>
>  lib/Transforms/IPO/ArgumentPromotion.cpp<br>
>  lib/Transforms/Utils/BasicBlockUtils.cpp<br>
>  lib/Transforms/Utils/LoopSimplify.cpp<br>
>  lib/Transforms/Vectorize/BBVectorize.cpp<br>
><br>
> <D11325.30077.patch>_______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
<br>
This just seems like an obvious follow-up to the previous patch.<br>
LGTM with one comment:<br>
<br>
> Index: lib/Transforms/Vectorize/BBVectorize.cpp<br>
> ===================================================================<br>
> --- lib/Transforms/Vectorize/BBVectorize.cpp<br>
> +++ lib/Transforms/Vectorize/BBVectorize.cpp<br>
> @@ -2806,55 +2806,51 @@<br>
>                       Instruction *J, Instruction *K,<br>
>                       Instruction *&InsertionPt,<br>
>                       Instruction *&K1, Instruction *&K2) {<br>
> -    if (isa<StoreInst>(I)) {<br>
> -      AA->replaceWithNewValue(I, K);<br>
> -      AA->replaceWithNewValue(J, K);<br>
> -    } else {<br>
> -      Type *IType = I->getType();<br>
> -      Type *JType = J->getType();<br>
> +    if (isa<StoreInst>(I))<br>
> +      return;<br>
><br>
> [... lots of changes ...]<br>
><br>
>      }<br>
><br>
> [... more changes ...]<br>
<br>
It was pretty hard to read what was different here.  Can you split<br>
the early-return part of this into an initial NFC commit?<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>