<div dir="ltr">Hi Jonathan,<div>I just posted a review comment for your patch.</div><div>I think that for a patch like this it would make sense to look at git-blame and figure out who implemented YAML IO in LLVM, or who modified it last and then add them for review.</div><div>Thanks,</div><div>Alex</div></div><div class="gmail_extra"><br><div class="gmail_quote">2015-07-22 5:18 GMT-07:00 Jonathan Anderson <span dir="ltr"><<a href="mailto:jonathan.anderson@mun.ca" target="_blank">jonathan.anderson@mun.ca</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div>
<p dir="auto">Good morning,</p>

<p dir="auto">I’ve posted a patch to <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_D11137&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=DP4suDCk7TfbqjC-82mCv_yJwwCbWSVgcUdQgXlkw2g&s=O728vIvjKfZFkhiE8vQRfLsSLIJPnqAEqZ6xCqmU_8c&e=" target="_blank">http://reviews.llvm.org/D11137</a> that adds another constructor to <code>llvm::yaml::Input</code>, passing filename information through to the <code>llvm::yaml::Stream</code> for debugging purposes. That is, if it fails to parse <code>foo.yaml</code>, it will now report an error having occurred at <code>foo.yaml:7:1</code> rather than <code>YAML:7:1</code>.</p>

<p dir="auto">I added a reviewer to <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_D11137&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=DP4suDCk7TfbqjC-82mCv_yJwwCbWSVgcUdQgXlkw2g&s=O728vIvjKfZFkhiE8vQRfLsSLIJPnqAEqZ6xCqmU_8c&e=" target="_blank">http://reviews.llvm.org/D11137</a> based on the contents of <code>CODE_OWNERS.txt</code> a little over a week ago, but I haven’t heard any more since then. What’s the best way to find a reviewer for this change, other than the code ownership route?</p>

<p dir="auto">Thanks,</p>

<h2>Jonathan Anderson</h2>

<p dir="auto">Assistant Professor<br>
Electrical and Computer Engineering<br>
Memorial University of Newfoundland</p>

<p dir="auto"><a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__www.engr.mun.ca_-257Eanderson&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=DP4suDCk7TfbqjC-82mCv_yJwwCbWSVgcUdQgXlkw2g&s=QbMZUt-WK0ZSAnj2YYIGD7BKbQeAhIwhNqleJpZk2Xg&e=" target="_blank">http://www.engr.mun.ca/~anderson</a></p>

</div><br>_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
<br></blockquote></div><br></div>