<div dir="ltr">Thanks Matt!<br><br>While you're here, could I please point you at <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_D11262&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=gXUg4JtJ53vkcPSG8-4bqWWGvg0fJjcTclymmJluhyQ&s=j4YLmb3lfFaVGj9DhZVAQ7O5IwDgpi3uG8_wCGFoV6E&e=">http://reviews.llvm.org/D11262</a> ? Do you have any comments on this?<div><br></div><div>Cheers,</div><div><br></div><div>James</div></div><br><div class="gmail_quote"><div dir="ltr">On Mon, 20 Jul 2015 at 21:25 Matt Arsenault <<a href="mailto:Matthew.Arsenault@amd.com">Matthew.Arsenault@amd.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">arsenm added inline comments.<br>
<br>
================<br>
Comment at: test/Transforms/InstCombine/minmax-fp.ll:4-5<br>
@@ +3,4 @@<br>
+; CHECK-LABEL: @t1<br>
+; CHECK-NEXT: fcmp<br>
+; CHECK-NEXT: select<br>
+; CHECK-NEXT: fpext<br>
----------------<br>
I think these really need to check the operands of these instructions. At the very minimum, at least the fcmp compare type.<br>
<br>
Besides that LGTM<br>
<br>
<br>
Repository:<br>
  rL LLVM<br>
<br>
<a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_D11146&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=gXUg4JtJ53vkcPSG8-4bqWWGvg0fJjcTclymmJluhyQ&s=36DXiZHi1Z_f9LcbkKZRyqquMuJY7Lq2TQ9it4qNktI&e=" rel="noreferrer" target="_blank">http://reviews.llvm.org/D11146</a><br>
<br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>