<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On 17 July 2015 at 01:56, Anthony Pesch <span dir="ltr"><<a href="mailto:inolen@gmail.com" target="_blank">inolen@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">inolen added inline comments.<br>
<span class=""><br>
================<br>
Comment at: lib/Transforms/Scalar/MemCpyOptimizer.cpp:255<br>
@@ -261,3 +254,3 @@<br>
   // to insert a new range.  Handle this now.<br>
-  if (I == E || End < I->Start) {<br>
+  if (I == Ranges.end() || End < I->Start) {<br>
     MemsetRange &R = *Ranges.insert(I, MemsetRange());<br>
----------------<br>
</span><span class="">nicholas wrote:<br>
> Optional: consider hoisting "Ranges.end()" out to "range_iterator E = Ranges.end;". See <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_docs_CodingStandards.html-23don-2Dt-2Devaluate-2Dend-2Devery-2Dtime-2Dthrough-2Da-2Dloop&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=TqA1sSsgdqWaziYT82XiINKoCNeYVBSSUqz2e07k-0A&s=FPOVJZ1uwSShmcWKBo9kVCpRrwneArRZRjeTWOXrQQ8&e=" rel="noreferrer" target="_blank">http://llvm.org/docs/CodingStandards.html#don-t-evaluate-end-every-time-through-a-loop</a> .<br>
</span>I'd removed the end iterator local due to it being invalidated during the loop at the bottom which calls Ranges.erase().<br></blockquote><div><br></div><div>LGTM</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="HOEnZb"><div class="h5"><br>
<br>
Repository:<br>
  rL LLVM<br>
<br>
<a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_D11198&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=TqA1sSsgdqWaziYT82XiINKoCNeYVBSSUqz2e07k-0A&s=iMWOaKH4BRzMVrwDlGdd0PeQO5RMQwI2s-OLUIDWjg0&e=" rel="noreferrer" target="_blank">http://reviews.llvm.org/D11198</a><br></div></div></blockquote></div></div></div>