<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Jul 16, 2015 at 10:08 AM, Benjamin Kramer <span dir="ltr"><<a href="mailto:benny.kra@gmail.com" target="_blank">benny.kra@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
> On 16.07.2015, at 18:57, David Blaikie <<a href="mailto:dblaikie@gmail.com">dblaikie@gmail.com</a>> wrote:<br>
<span class="">><br>
><br>
><br>
> On Thu, Jul 16, 2015 at 4:12 AM, Benjamin Kramer <<a href="mailto:benny.kra@googlemail.com">benny.kra@googlemail.com</a>> wrote:<br>
> Author: d0k<br>
> Date: Thu Jul 16 06:12:05 2015<br>
> New Revision: 242393<br>
><br>
> URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject-3Frev-3D242393-26view-3Drev&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=K9JGa8uLmqYfMr1ReeWWBd1_7kYJVsliIDTOBBPNFAU&s=N8HGaXowq_5UikSKhvC0TCHkg9PYH0Kn1w8CQqYvr98&e=" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=242393&view=rev</a><br>
</span><span class="">> Log:<br>
> [Mips] Make helper function static, NFC.<br>
><br>
> Just curious: are you or have you tried turning on -Wmissing-prototypes?<br>
<br>
</span>I have it switched on for my local build, but there are some false positives, especially weirdly layered tblgenerated stuff.<br></blockquote><div><br></div><div>Anything you reckon we can do about them (either in code changes or changes to the diagnostic)?<br><br>- David</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
- Ben<br>
<span class=""><br>
><br>
><br>
> Modified:<br>
>     llvm/trunk/lib/Target/Mips/MipsSEFrameLowering.cpp<br>
><br>
> Modified: llvm/trunk/lib/Target/Mips/MipsSEFrameLowering.cpp<br>
> URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_llvm_trunk_lib_Target_Mips_MipsSEFrameLowering.cpp-3Frev-3D242393-26r1-3D242392-26r2-3D242393-26view-3Ddiff&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=K9JGa8uLmqYfMr1ReeWWBd1_7kYJVsliIDTOBBPNFAU&s=9bC_XOXITflUp3aPrnMQ7JdQyZeKfFD6O0hNcptEqLA&e=" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/Mips/MipsSEFrameLowering.cpp?rev=242393&r1=242392&r2=242393&view=diff</a><br>
</span><span class="">> ==============================================================================<br>
> --- llvm/trunk/lib/Target/Mips/MipsSEFrameLowering.cpp (original)<br>
> +++ llvm/trunk/lib/Target/Mips/MipsSEFrameLowering.cpp Thu Jul 16 06:12:05 2015<br>
> @@ -622,7 +622,8 @@ MipsSEFrameLowering::hasReservedCallFram<br>
>  }<br>
><br>
>  /// Mark \p Reg and all registers aliasing it in the bitset.<br>
> -void setAliasRegs(MachineFunction &MF, BitVector &SavedRegs, unsigned Reg) {<br>
> +static void setAliasRegs(MachineFunction &MF, BitVector &SavedRegs,<br>
> +                         unsigned Reg) {<br>
>    const TargetRegisterInfo *TRI = MF.getSubtarget().getRegisterInfo();<br>
>    for (MCRegAliasIterator AI(Reg, TRI, true); AI.isValid(); ++AI)<br>
>      SavedRegs.set(*AI);<br>
><br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
</span>> <a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
><br>
<br>
</blockquote></div><br></div></div>