<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Jul 15, 2015, at 4:25 PM, Chandler Carruth <<a href="mailto:chandlerc@google.com" class="">chandlerc@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">I thought this was no longer going forward in favor of the other patches I've been reviewing...<div class=""><br class=""></div><div class="">Michael, leme know if I should still look at this.</div></div></div></blockquote>Yes, please! This patch is also still relevant.</div><div><br class=""></div><div>Thanks,</div><div>Michael<br class=""><blockquote type="cite" class=""><div class=""><br class=""><div class="gmail_quote"><div dir="ltr" class="">On Wed, Jul 15, 2015 at 4:21 PM Gerolf Hoflehner <<a href="mailto:ghoflehner@apple.com" class="">ghoflehner@apple.com</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Was there an update?<br class="">
<br class="">
Thanks<br class="">
Gerolf<br class="">
> On Jul 7, 2015, at 10:28 PM, Michael Zolotukhin <<a href="mailto:mzolotukhin@apple.com" target="_blank" class="">mzolotukhin@apple.com</a>> wrote:<br class="">
><br class="">
> mzolotukhin marked an inline comment as done.<br class="">
><br class="">
> Thanks, Gerolf,<br class="">
> I'll update the comments.<br class="">
><br class="">
><br class="">
> ================<br class="">
> Comment at: lib/Transforms/Scalar/LoopUnrollPass.cpp:635<br class="">
> @@ -620,3 +634,3 @@<br class="">
> // won't find them on later ones too.<br class="">
> if (UnrolledCost == RolledDynamicCost)<br class="">
> return None;<br class="">
> ----------------<br class="">
> Gerolf wrote:<br class="">
>> I'm missing context. Where do the costs get computed?<br class="">
> On lines 594, 598.<br class="">
><br class="">
><br class="">
> <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_D8817&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=x9eOzpiYMOnZB_Jbgre_rv1dKbPP9kHD4Ev4Q2aRdbk&s=D6IlRds4PpH8nPUKYAPJg7mE7boYVAJx27Jj3LSW658&e=" rel="noreferrer" target="_blank" class="">http://reviews.llvm.org/D8817</a><br class="">
><br class="">
><br class="">
><br class="">
<br class="">
<br class="">
_______________________________________________<br class="">
llvm-commits mailing list<br class="">
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank" class="">llvm-commits@cs.uiuc.edu</a><br class="">
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank" class="">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br class="">
</blockquote></div>
_______________________________________________<br class="">llvm-commits mailing list<br class=""><a href="mailto:llvm-commits@cs.uiuc.edu" class="">llvm-commits@cs.uiuc.edu</a><br class="">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits<br class=""></div></blockquote></div><br class=""></body></html>