<div dir="ltr">I thought this was no longer going forward in favor of the other patches I've been reviewing...<div><br></div><div>Michael, leme know if I should still look at this.</div></div><br><div class="gmail_quote"><div dir="ltr">On Wed, Jul 15, 2015 at 4:21 PM Gerolf Hoflehner <<a href="mailto:ghoflehner@apple.com">ghoflehner@apple.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Was there an update?<br>
<br>
Thanks<br>
Gerolf<br>
> On Jul 7, 2015, at 10:28 PM, Michael Zolotukhin <<a href="mailto:mzolotukhin@apple.com" target="_blank">mzolotukhin@apple.com</a>> wrote:<br>
><br>
> mzolotukhin marked an inline comment as done.<br>
><br>
> Thanks, Gerolf,<br>
> I'll update the comments.<br>
><br>
><br>
> ================<br>
> Comment at: lib/Transforms/Scalar/LoopUnrollPass.cpp:635<br>
> @@ -620,3 +634,3 @@<br>
>     // won't find them on later ones too.<br>
>     if (UnrolledCost == RolledDynamicCost)<br>
>       return None;<br>
> ----------------<br>
> Gerolf wrote:<br>
>> I'm missing context. Where do the costs get computed?<br>
> On lines 594, 598.<br>
><br>
><br>
> <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_D8817&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=x9eOzpiYMOnZB_Jbgre_rv1dKbPP9kHD4Ev4Q2aRdbk&s=D6IlRds4PpH8nPUKYAPJg7mE7boYVAJx27Jj3LSW658&e=" rel="noreferrer" target="_blank">http://reviews.llvm.org/D8817</a><br>
><br>
><br>
><br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>