<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Jul 14, 2015, at 1:28 PM, David Blaikie <<a href="mailto:dblaikie@gmail.com" class="">dblaikie@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class=""><br class=""><div class="gmail_extra"><br class=""><div class="gmail_quote">On Tue, Jul 14, 2015 at 11:21 AM, Pete Cooper <span dir="ltr" class=""><<a href="mailto:peter_cooper@apple.com" target="_blank" class="">peter_cooper@apple.com</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Out of curiosity, are init lists unsupported anywhere on MSVC, or just in argument defaults? Just want to make sure I don’t commit something unsupported in future.<br class=""></blockquote><div class=""><br class="">Not sure, but it doesn't seem to be "everywhere" - check the corresponding Clang change where callers were already successfully passing "{}" for this argument (& the change just drops that argument) (& all the other CreateCall sites are using {A, B, C], etc… )<br class=""></div></div></div></div></div></blockquote>Hmm, interesting. I think the word ‘inconsistent’ springs to mind :)</div><div><br class=""></div><div>Thanks for the answer. For now i’m going to assume that using them as default arguments is bad for some strange reason.</div><div>Pete<br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""><div class="gmail_extra"><div class="gmail_quote"><div class=""> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<span class="HOEnZb"><font color="#888888" class=""><br class="">
Pete<br class="">
</font></span><div class="HOEnZb"><div class="h5">> On Jul 14, 2015, at 10:40 AM, David Blaikie <<a href="mailto:dblaikie@gmail.com" class="">dblaikie@gmail.com</a>> wrote:<br class="">
><br class="">
> Author: dblaikie<br class="">
> Date: Tue Jul 14 12:40:53 2015<br class="">
> New Revision: 242170<br class="">
><br class="">
> URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject-3Frev-3D242170-26view-3Drev&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=S1cqKIX9umGfL6kRqyYDKe8erqJj7WA_ZiUQkpwPL_Y&s=mfWwCOBYISUntzcnKGDruevQR8thgC7Dvt7CQI5Kfso&e=" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-project?rev=242170&view=rev</a><br class="">
> Log:<br class="">
> Avoid MSVC-incompatible use of init list.<br class="">
><br class="">
> Modified:<br class="">
> llvm/trunk/include/llvm/IR/IRBuilder.h<br class="">
><br class="">
> Modified: llvm/trunk/include/llvm/IR/IRBuilder.h<br class="">
> URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_llvm_trunk_include_llvm_IR_IRBuilder.h-3Frev-3D242170-26r1-3D242169-26r2-3D242170-26view-3Ddiff&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=S1cqKIX9umGfL6kRqyYDKe8erqJj7WA_ZiUQkpwPL_Y&s=o9d5dDY-WXseXupoPqraRti8k92UBcK2Ya9sIU4ml1A&e=" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/IR/IRBuilder.h?rev=242170&r1=242169&r2=242170&view=diff</a><br class="">
> ==============================================================================<br class="">
> --- llvm/trunk/include/llvm/IR/IRBuilder.h (original)<br class="">
> +++ llvm/trunk/include/llvm/IR/IRBuilder.h Tue Jul 14 12:40:53 2015<br class="">
> @@ -1464,7 +1464,7 @@ public:<br class="">
> return Insert(PHINode::Create(Ty, NumReservedValues), Name);<br class="">
> }<br class="">
><br class="">
> - CallInst *CreateCall(Value *Callee, ArrayRef<Value *> Args = {},<br class="">
> + CallInst *CreateCall(Value *Callee, ArrayRef<Value *> Args = None,<br class="">
> const Twine &Name = "") {<br class="">
> return Insert(CallInst::Create(Callee, Args), Name);<br class="">
> }<br class="">
><br class="">
><br class="">
> _______________________________________________<br class="">
> llvm-commits mailing list<br class="">
> <a href="mailto:llvm-commits@cs.uiuc.edu" class="">llvm-commits@cs.uiuc.edu</a><br class="">
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank" class="">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br class="">
<br class="">
</div></div></blockquote></div><br class=""></div></div>
</div></blockquote></div><br class=""></body></html>