<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Jul 14, 2015 at 11:21 AM, Pete Cooper <span dir="ltr"><<a href="mailto:peter_cooper@apple.com" target="_blank">peter_cooper@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Out of curiosity, are init lists unsupported anywhere on MSVC, or just in argument defaults?  Just want to make sure I don’t commit something unsupported in future.<br></blockquote><div><br>Not sure, but it doesn't seem to be "everywhere" - check the corresponding Clang change where callers were already successfully passing "{}" for this argument (& the change just drops that argument) (& all the other CreateCall sites are using {A, B, C], etc... )<br> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<span class="HOEnZb"><font color="#888888"><br>
Pete<br>
</font></span><div class="HOEnZb"><div class="h5">> On Jul 14, 2015, at 10:40 AM, David Blaikie <<a href="mailto:dblaikie@gmail.com">dblaikie@gmail.com</a>> wrote:<br>
><br>
> Author: dblaikie<br>
> Date: Tue Jul 14 12:40:53 2015<br>
> New Revision: 242170<br>
><br>
> URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject-3Frev-3D242170-26view-3Drev&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=3mUNcLFKI9baZ7HJDEEsyJ43E0kB3KBn1gSVHIk8p3U&s=p_4PhNQsN3bmdj32D1uPOVgYS-xhnHQ3ThI8V5L53k8&e=" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=242170&view=rev</a><br>
> Log:<br>
> Avoid MSVC-incompatible use of init list.<br>
><br>
> Modified:<br>
>    llvm/trunk/include/llvm/IR/IRBuilder.h<br>
><br>
> Modified: llvm/trunk/include/llvm/IR/IRBuilder.h<br>
> URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_llvm_trunk_include_llvm_IR_IRBuilder.h-3Frev-3D242170-26r1-3D242169-26r2-3D242170-26view-3Ddiff&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=3mUNcLFKI9baZ7HJDEEsyJ43E0kB3KBn1gSVHIk8p3U&s=HkGDc6SBNmYarYQZIkaJoDmXj3LFZZbs1YEFRah4lBo&e=" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/IR/IRBuilder.h?rev=242170&r1=242169&r2=242170&view=diff</a><br>
> ==============================================================================<br>
> --- llvm/trunk/include/llvm/IR/IRBuilder.h (original)<br>
> +++ llvm/trunk/include/llvm/IR/IRBuilder.h Tue Jul 14 12:40:53 2015<br>
> @@ -1464,7 +1464,7 @@ public:<br>
>     return Insert(PHINode::Create(Ty, NumReservedValues), Name);<br>
>   }<br>
><br>
> -  CallInst *CreateCall(Value *Callee, ArrayRef<Value *> Args = {},<br>
> +  CallInst *CreateCall(Value *Callee, ArrayRef<Value *> Args = None,<br>
>                        const Twine &Name = "") {<br>
>     return Insert(CallInst::Create(Callee, Args), Name);<br>
>   }<br>
><br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
<br>
</div></div></blockquote></div><br></div></div>