<div dir="ltr">When the outer loop is rotated, the inner loop is already linked to other CFG nodes in the outer loop. So I think we won't have to adjust the current algorithm as we have already considered all costs the rotation may bring or reduce.<div><br></div><div class="gmail_extra"><br clear="all"><div><div class="gmail_signature">thanks,<br>Cong</div></div>
<br><div class="gmail_quote">On Mon, Jul 6, 2015 at 9:57 AM, Xinliang David Li <span dir="ltr"><<a href="mailto:xinliangli@gmail.com" target="_blank">xinliangli@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Does the cost analysis work well for loop nest? After the inner loop chain is formed and rotated, it will be later be merged into the parent loop chain. The cost analysis for the parent loop may need to be adjusted to consider the inner loops that are already rotated.<div><br></div><div>David</div></div><div class="gmail_extra"><br><div class="gmail_quote"><div><div class="h5">On Tue, Jun 30, 2015 at 2:29 PM, Cong Hou <span dir="ltr"><<a href="mailto:congh@google.com" target="_blank">congh@google.com</a>></span> wrote:<br></div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div class="h5">Update the patch by adding two opt parameters that define the cost of misfetch and jump instruction, and use them when rotating loops.<br>
<div><div><br>
<br>
<a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_D10717&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=wiXFhaTG9PkUzZ_FYr3OYcbQ2v5J8VdDEHMBc_g6MS8&s=ijAv9cIAuuBdi4pHAP2voW4migCMaypFU_-hXtx7_uw&e=" rel="noreferrer" target="_blank">http://reviews.llvm.org/D10717</a><br>
<br>
Files:<br>
  lib/CodeGen/MachineBlockPlacement.cpp<br>
  test/CodeGen/X86/code_placement_loop_rotation.ll<br>
<br>
EMAIL PREFERENCES<br>
  <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_settings_panel_emailpreferences_&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=wiXFhaTG9PkUzZ_FYr3OYcbQ2v5J8VdDEHMBc_g6MS8&s=zL9ySdMGVlPZaOIqzGcMCzgvKitWIID1f1JxB3Y467Y&e=" rel="noreferrer" target="_blank">http://reviews.llvm.org/settings/panel/emailpreferences/</a><br>
</div></div><br></div></div>_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
<br></blockquote></div><br></div>
</blockquote></div><br></div></div>