<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Jul 2, 2015 at 9:28 AM, Rafael Espíndola <span dir="ltr"><<a href="mailto:rafael.espindola@gmail.com" target="_blank">rafael.espindola@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">On 2 July 2015 at 12:21, David Blaikie <<a href="mailto:dblaikie@gmail.com">dblaikie@gmail.com</a>> wrote:<br>
><br>
><br>
> On Thu, Jul 2, 2015 at 4:48 AM, Rafael Espindola<br>
> <<a href="mailto:rafael.espindola@gmail.com">rafael.espindola@gmail.com</a>> wrote:<br>
>><br>
>> Author: rafael<br>
>> Date: Thu Jul  2 06:48:48 2015<br>
>> New Revision: 241255<br>
>><br>
>> URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject-3Frev-3D241255-26view-3Drev&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=X2t0mb1yhsMPJFF2yJp_hnu8i2L8Ystssoj9k67eUMQ&s=LfK2_YExQT-zX6YGsJ-natu3nWDB0BhMxncoAQtu3Bo&e=" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=241255&view=rev</a><br>
>> Log:<br>
>> Improve error message.<br>
>><br>
>> Thanks to Sean Silva for the suggestion.<br>
>><br>
>> Modified:<br>
>>     llvm/trunk/include/llvm/Object/ELF.h<br>
>>     llvm/trunk/test/Object/invalid.test<br>
>><br>
>> Modified: llvm/trunk/include/llvm/Object/ELF.h<br>
>> URL:<br>
>> <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_llvm_trunk_include_llvm_Object_ELF.h-3Frev-3D241255-26r1-3D241254-26r2-3D241255-26view-3Ddiff&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=X2t0mb1yhsMPJFF2yJp_hnu8i2L8Ystssoj9k67eUMQ&s=8WMHtdQvTqW3nEDaSYqQ_zgkq0IzoZLhrXUfpaFvxbg&e=" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Object/ELF.h?rev=241255&r1=241254&r2=241255&view=diff</a><br>
>><br>
>> ==============================================================================<br>
>> --- llvm/trunk/include/llvm/Object/ELF.h (original)<br>
>> +++ llvm/trunk/include/llvm/Object/ELF.h Thu Jul  2 06:48:48 2015<br>
>> @@ -765,7 +765,8 @@ uint64_t ELFFile<ELFT>::getSymbolIndex(c<br>
>>  template <class ELFT><br>
>>  const typename ELFFile<ELFT>::Elf_Shdr *ELFFile<ELFT>::section_begin()<br>
>> const {<br>
>>    if (Header->e_shentsize != sizeof(Elf_Shdr))<br>
>> -    report_fatal_error("Invalid section header size");<br>
>> +    report_fatal_error(<br>
>> +        "Invalid section header entry size (e_shentsize) in ELF header");<br>
><br>
><br>
> Vaguely: Don't we need things in libObject to be non-fatal, since it's used<br>
> as a library in programs that might want to not crash/abort on failure, I<br>
> would imagine?<br>
<br>
</div></div>Yes. We need to have a proper diagnostic handler in place.<br>
<br>
This at least went from silently ignoring the error to reporting it. I<br>
will clean this all up, but there is a lot to do and this was a step<br>
in the right direction.<br></blockquote><div><br>Sure thing - thanks for the context/details!<br> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Cheers,<br>
Rafael<br>
</blockquote></div><br></div></div>