<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Jul 2, 2015 at 4:48 AM, Rafael Espindola <span dir="ltr"><<a href="mailto:rafael.espindola@gmail.com" target="_blank">rafael.espindola@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: rafael<br>
Date: Thu Jul  2 06:48:48 2015<br>
New Revision: 241255<br>
<br>
URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject-3Frev-3D241255-26view-3Drev&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=8PUSFZZUAVJuvvFGZt1NCS0EZuEHnlMdxNBC0NWgNV8&s=zbU2eBCl4DwCHB2x8sBjbJInZGT8QpGpnPbfBJxUzHA&e=" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=241255&view=rev</a><br>
Log:<br>
Improve error message.<br>
<br>
Thanks to Sean Silva for the suggestion.<br>
<br>
Modified:<br>
    llvm/trunk/include/llvm/Object/ELF.h<br>
    llvm/trunk/test/Object/invalid.test<br>
<br>
Modified: llvm/trunk/include/llvm/Object/ELF.h<br>
URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_llvm_trunk_include_llvm_Object_ELF.h-3Frev-3D241255-26r1-3D241254-26r2-3D241255-26view-3Ddiff&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=8PUSFZZUAVJuvvFGZt1NCS0EZuEHnlMdxNBC0NWgNV8&s=gM_ROOB1OrC3cVUM6fgwwhxAKH7WdYA2bNs6MIbseRI&e=" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Object/ELF.h?rev=241255&r1=241254&r2=241255&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/include/llvm/Object/ELF.h (original)<br>
+++ llvm/trunk/include/llvm/Object/ELF.h Thu Jul  2 06:48:48 2015<br>
@@ -765,7 +765,8 @@ uint64_t ELFFile<ELFT>::getSymbolIndex(c<br>
 template <class ELFT><br>
 const typename ELFFile<ELFT>::Elf_Shdr *ELFFile<ELFT>::section_begin() const {<br>
   if (Header->e_shentsize != sizeof(Elf_Shdr))<br>
-    report_fatal_error("Invalid section header size");<br>
+    report_fatal_error(<br>
+        "Invalid section header entry size (e_shentsize) in ELF header");<br></blockquote><div><br></div><div>Vaguely: Don't we need things in libObject to be non-fatal, since it's used as a library in programs that might want to not crash/abort on failure, I would imagine?</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
   return reinterpret_cast<const Elf_Shdr *>(base() + Header->e_shoff);<br>
 }<br>
<br>
<br>
Modified: llvm/trunk/test/Object/invalid.test<br>
URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_llvm_trunk_test_Object_invalid.test-3Frev-3D241255-26r1-3D241254-26r2-3D241255-26view-3Ddiff&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=8PUSFZZUAVJuvvFGZt1NCS0EZuEHnlMdxNBC0NWgNV8&s=Ls3OjvyB7aJzJyv7SkXsfrcrYg3-609ButK4-vSFNT8&e=" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Object/invalid.test?rev=241255&r1=241254&r2=241255&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/test/Object/invalid.test (original)<br>
+++ llvm/trunk/test/Object/invalid.test Thu Jul  2 06:48:48 2015<br>
@@ -43,4 +43,4 @@ RUN: not llvm-readobj -t %p/Inputs/inval<br>
 INVALID-SECTION-INDEX: Invalid section index<br>
<br>
 RUN: not llvm-readobj -s %p/Inputs/invalid-section-size.elf 2>&1 | FileCheck --check-prefix=INVALID-SECTION-SIZE %s<br>
-INVALID-SECTION-SIZE: Invalid section header size<br>
+INVALID-SECTION-SIZE: Invalid section header entry size (e_shentsize) in ELF header<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div></div>