<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">2015-06-29 18:36 GMT-07:00 Sean Silva <span dir="ltr"><<a href="mailto:chisophugis@gmail.com" target="_blank">chisophugis@gmail.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">LGTM with a nit.<br>
<br>
<br>
REPOSITORY<br>
  rL LLVM<br>
<br>
================<br>
Comment at: lib/CodeGen/MIRParser/MILexer.cpp:182<br>
@@ -164,16 +181,3 @@<br>
<br>
-  auto Char = C.peek();<br>
-  if (isalpha(Char) || Char == '_')<br>
-    return lexIdentifier(C, Token).remaining();<br>
-  if (Char == '%') {<br>
-    if (C.remaining().startswith("%bb."))<br>
-      return lexMachineBasicBlock(C, Token, ErrorCallback).remaining();<br>
-    return lexPercent(C, Token).remaining();<br>
-  }<br>
-  if (Char == '@')<br>
-    return lexGlobalValue(C, Token).remaining();<br>
-  if (isdigit(Char) || (Char == '-' && isdigit(C.peek(1))))<br>
-    return lexIntegerLiteral(C, Token).remaining();<br>
-  MIToken::TokenKind Kind = symbolToken(Char);<br>
-  if (Kind != MIToken::Error)<br>
-    return lexSymbol(C, Kind, Token).remaining();<br>
+  if (auto R = maybeLexIdentifier(C, Token))<br>
+    return R.remaining();<br>
----------------<br>
Even though I know this pattern returns a cursor, I found myself looking around to confirm that the `auto` was hiding a cursor. I would prefer to just say `Cursor`.<br></blockquote><div><br></div><div>Thanks, I will commit this patch with 'auto' replaced by 'Cursor'.</div><div>Alex</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
<a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_D10817&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=Wub7UYcn-J2oP5uZ2tbnQduf0Pi56cmruKrlAE16yoA&s=jQoPHVyXwFazGq5A2Ds1kGhMp6UKYVtd7R0YctH-lgI&e=" rel="noreferrer" target="_blank">http://reviews.llvm.org/D10817</a><br>
<br>
EMAIL PREFERENCES<br>
  <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_settings_panel_emailpreferences_&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=Wub7UYcn-J2oP5uZ2tbnQduf0Pi56cmruKrlAE16yoA&s=z5ENhbxWTfyUy8JKQm1taE3ZYEM33GeDiGJaNsshfi4&e=" rel="noreferrer" target="_blank">http://reviews.llvm.org/settings/panel/emailpreferences/</a><br>
<br>
<br>
</blockquote></div><br></div></div>