<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Jun 29, 2015 at 2:46 PM, Rui Ueyama <span dir="ltr"><<a href="mailto:ruiu@google.com" target="_blank">ruiu@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: ruiu<br>
Date: Mon Jun 29 16:46:46 2015<br>
New Revision: 241004<br>
<br>
URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject-3Frev-3D241004-26view-3Drev&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=lsTrnJfq7K9vsPlhR1OGJUBxx-BjEPcQJe8dJPIS2BM&s=YJEM3ozkVACmS_K5O0B7VjLm6Fg0yqC8JHnu5khCZkw&e=" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=241004&view=rev</a><br>
Log:<br>
Silence MSVC "not all control paths return a value" warning.<br>
<br>
Modified:<br>
    lld/trunk/COFF/Symbols.cpp<br>
<br>
Modified: lld/trunk/COFF/Symbols.cpp<br>
URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_lld_trunk_COFF_Symbols.cpp-3Frev-3D241004-26r1-3D241003-26r2-3D241004-26view-3Ddiff&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=lsTrnJfq7K9vsPlhR1OGJUBxx-BjEPcQJe8dJPIS2BM&s=2HW9fDT1Uc-1U3g4oAJZMDCi6HRuYr7mx1ctvsPkvPM&e=" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/COFF/Symbols.cpp?rev=241004&r1=241003&r2=241004&view=diff</a><br>
==============================================================================<br>
--- lld/trunk/COFF/Symbols.cpp (original)<br>
+++ lld/trunk/COFF/Symbols.cpp Mon Jun 29 16:46:46 2015<br>
@@ -129,6 +129,8 @@ int SymbolBody::compare(SymbolBody *Othe<br>
   case DefinedAbsoluteKind:<br>
     // These all simply tie.<br>
     return 0;<br>
+  default:<br>
+    llvm_unreachable("unknown symbol kind");<br></blockquote><div><br></div><div>This may cause a -Wswitch-covered-default in Clang (if that's a switch over an enum, and there's a case for every enumerator). The usual fix is to put the unreachable after the switch rather than introducing a default.<br><br>Same potential issue with the next one too.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
   }<br>
 }<br>
<br>
@@ -161,6 +163,8 @@ uint64_t Defined::getRVA() {<br>
   case LazyKind:<br>
   case UndefinedKind:<br>
     llvm_unreachable("Cannot get the address for an undefined symbol.");<br>
+  default:<br>
+    llvm_unreachable("unknown symbol kind");<br>
   }<br>
 }<br>
<br>
@@ -184,6 +188,8 @@ uint64_t Defined::getFileOff() {<br>
   case LazyKind:<br>
   case UndefinedKind:<br>
     llvm_unreachable("Cannot get a file offset for an undefined symbol.");<br>
+  default:<br>
+    llvm_unreachable("unknown symbol kind");<br>
   }<br>
 }<br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div></div>