<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Jun 25, 2015 at 4:44 PM, Adrian Prantl <span dir="ltr"><<a href="mailto:aprantl@apple.com" target="_blank">aprantl@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">These four properties are certainly very specific to clang modules.<br></blockquote><div><br>More than that, though - I was trying to wonder how definitive they are - how likely to add/remove things in this set of things, etc.<br> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Since they need to get translated into custom DW_AT_LLVM_key("value") by the backend, </blockquote><div><br>Well, I was wondering if the DWARF encoding could be similarly opaque.<br> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">we could implement a generic mechanism like:<br>
<br>
  // assuming that DW_AT_LLVM_config_macros = DW_AT_lo_user = 0x2500<br>
  !2 = !DIModule(scope: !0, name: "Module", stringAttrs: !{ i32 9472, !"-DNDEBUG", ...})<br>
<br>
... which the backend then interprets as a list of DW_FORM_strp attributes.<br>
But since we don't have named constants in the IR to make this more readable, I'm not convinced that this is preferable at the moment.<br></blockquote><div><br>Anyway, I suppose the metadata schema is extensible enough these days - the churn just seems painful when adding/removing fields, etc.<br><br>Carry on/looks good/please commit/etc.<br> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<span class=""><br>
<br>
REPOSITORY<br>
  rL LLVM<br>
<br>
<a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_D9614&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=DlcLMXGYYIz0rctB0ChGNRMltKjErYAIBcbNFkiqkaM&s=o7cYI64P18x2PbXAU_5KltWjH-Q5bdLFJrhoVdqHI0o&e=" rel="noreferrer" target="_blank">http://reviews.llvm.org/D9614</a><br>
<br>
</span>EMAIL PREFERENCES<br>
  <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_settings_panel_emailpreferences_&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=DlcLMXGYYIz0rctB0ChGNRMltKjErYAIBcbNFkiqkaM&s=ruviX2p7Jw9HI46Inu3Z6HmSfFLDA1Fd11lO0zXN0ZI&e=" rel="noreferrer" target="_blank">http://reviews.llvm.org/settings/panel/emailpreferences/</a><br>
<br>
<br>
</blockquote></div><br></div></div>