<div dir="ltr">Do we have a way to see these now?<div><br></div><div>-- Sean Silva</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Jun 25, 2015 at 2:00 PM, Rafael Espindola <span dir="ltr"><<a href="mailto:rafael.espindola@gmail.com" target="_blank">rafael.espindola@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: rafael<br>
Date: Thu Jun 25 16:00:51 2015<br>
New Revision: 240695<br>
<br>
URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject-3Frev-3D240695-26view-3Drev&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=cbx9k58gUqW5ntWwfixp4auBFiXQVgLIxQhLfExgAk0&s=sQOVB_amr3lMa_iSQbo3wriETPqcPlJsy_YLHGH1SKg&e=" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=240695&view=rev</a><br>
Log:<br>
llvm-nm: Don't print mapping symbols.<br>
<br>
This matches the behavior of gnu nm. Fixes pr23930.<br>
<br>
Added:<br>
    llvm/trunk/test/Object/ARM/nm-mapping-symbol.s<br>
Modified:<br>
    llvm/trunk/include/llvm/Object/ELFObjectFile.h<br>
<br>
Modified: llvm/trunk/include/llvm/Object/ELFObjectFile.h<br>
URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_llvm_trunk_include_llvm_Object_ELFObjectFile.h-3Frev-3D240695-26r1-3D240694-26r2-3D240695-26view-3Ddiff&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=cbx9k58gUqW5ntWwfixp4auBFiXQVgLIxQhLfExgAk0&s=FfWc-GiG3Ce2j9kROtZIXtbRvqCH0uM6py47j-Ql1bg&e=" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Object/ELFObjectFile.h?rev=240695&r1=240694&r2=240695&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/include/llvm/Object/ELFObjectFile.h (original)<br>
+++ llvm/trunk/include/llvm/Object/ELFObjectFile.h Thu Jun 25 16:00:51 2015<br>
@@ -394,6 +394,15 @@ uint32_t ELFObjectFile<ELFT>::getSymbolF<br>
       EIter == EF.begin_symbols() || EIter == EF.begin_dynamic_symbols())<br>
     Result |= SymbolRef::SF_FormatSpecific;<br>
<br>
+  if (EF.getHeader()->e_machine == ELF::EM_ARM) {<br>
+    if (ErrorOr<StringRef> NameOrErr = EF.getSymbolName(EIter)) {<br>
+      StringRef Name = *NameOrErr;<br>
+      if (Name.startswith("$d") || Name.startswith("$t") ||<br>
+          Name.startswith("$a"))<br>
+        Result |= SymbolRef::SF_FormatSpecific;<br>
+    }<br>
+  }<br>
+<br>
   if (ESym->st_shndx == ELF::SHN_UNDEF)<br>
     Result |= SymbolRef::SF_Undefined;<br>
<br>
<br>
Added: llvm/trunk/test/Object/ARM/nm-mapping-symbol.s<br>
URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_llvm_trunk_test_Object_ARM_nm-2Dmapping-2Dsymbol.s-3Frev-3D240695-26view-3Dauto&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=cbx9k58gUqW5ntWwfixp4auBFiXQVgLIxQhLfExgAk0&s=rAcre0S59DHuzD4-U-ocoKxVV3oqkJ1IG9GYiRf0TIQ&e=" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Object/ARM/nm-mapping-symbol.s?rev=240695&view=auto</a><br>
==============================================================================<br>
--- llvm/trunk/test/Object/ARM/nm-mapping-symbol.s (added)<br>
+++ llvm/trunk/test/Object/ARM/nm-mapping-symbol.s Thu Jun 25 16:00:51 2015<br>
@@ -0,0 +1,11 @@<br>
+// RUN: llvm-mc %s -o %t.o -filetype=obj -triple=armv7-pc-linux<br>
+// RUN: llvm-readobj -t %t.o | FileCheck %s<br>
+// RUN: llvm-nm %t.o | FileCheck -allow-empty --check-prefix=NM %s<br>
+<br>
+// Test that nm doesn't print the mapping symbols<br>
+<br>
+// CHECK: Name: $d.0<br>
+// NM-NOT: $d.0<br>
+<br>
+        .section        .foobar,"",%progbits<br>
+        .asciz  "foo"<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>