<div dir="ltr">Thanks, <div>I'll rename it to "IRSlots" and commit it soon.</div><div>I didn't commit a MBB operand patch yet, so I can rename 'MBBMapping' to 'MBBSlots' prior to committing :P</div><div>Cheers,</div><div>Alex</div></div><div class="gmail_extra"><br><div class="gmail_quote">2015-06-25 12:38 GMT-07:00 Duncan P. N. Exon Smith <span dir="ltr"><<a href="mailto:dexonsmith@apple.com" target="_blank">dexonsmith@apple.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5"><br>
> On 2015-Jun-23, at 16:07, Alex Lorenz <<a href="mailto:arphaman@gmail.com">arphaman@gmail.com</a>> wrote:<br>
><br>
> Hi dexonsmith, bob.wilson, bogner,<br>
><br>
> This patch is based on a previous serialization patch that serializes MBB operands (<a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_D10608&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=NNCBQlpCfim9jjzskFqUpLkkVpXWfuDISTHB-HXP0rE&s=MAODPK90s-F1AOSjDgDjDQznJsOSf1HL187Zv8cN_Iw&e=" rel="noreferrer" target="_blank">http://reviews.llvm.org/D10608</a>).<br>
><br>
> This patch serializes the global address machine operands.<br>
><br>
> REPOSITORY<br>
>  rL LLVM<br>
><br>
> <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_D10671&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=NNCBQlpCfim9jjzskFqUpLkkVpXWfuDISTHB-HXP0rE&s=GlLY6Y8ilJwMEZvCxpRR3TBGpLWonFANbvc9fqLEH70&e=" rel="noreferrer" target="_blank">http://reviews.llvm.org/D10671</a><br>
><br>
> Files:<br>
>  lib/CodeGen/MIRParser/MILexer.cpp<br>
>  lib/CodeGen/MIRParser/MILexer.h<br>
>  lib/CodeGen/MIRParser/MIParser.cpp<br>
>  lib/CodeGen/MIRParser/MIParser.h<br>
>  lib/CodeGen/MIRParser/MIRParser.cpp<br>
>  lib/CodeGen/MIRPrinter.cpp<br>
>  test/CodeGen/MIR/X86/global-value-operands.mir<br>
>  test/CodeGen/MIR/X86/invalid-global-value-index.mir<br>
>  test/CodeGen/MIR/X86/undefined-global-value.mir<br>
><br>
> EMAIL PREFERENCES<br>
>  <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_settings_panel_emailpreferences_&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=NNCBQlpCfim9jjzskFqUpLkkVpXWfuDISTHB-HXP0rE&s=QWy3fPtyT6B_N-y1uGqq56I8YEdj17mX9speACXOuF8&e=" rel="noreferrer" target="_blank">http://reviews.llvm.org/settings/panel/emailpreferences/</a><br>
</div></div>> <D10671.28299.patch><br>
<br>
> Index: lib/CodeGen/MIRParser/MIParser.cpp<br>
> ===================================================================<br>
> --- lib/CodeGen/MIRParser/MIParser.cpp<br>
> +++ lib/CodeGen/MIRParser/MIParser.cpp<br>
> @@ -34,15 +36,18 @@<br>
>    MIToken Token;<br>
>    /// Maps from basic block numbers to MBBs.<br>
>    const DenseMap<unsigned, MachineBasicBlock *> &MBBMapping;<br>
> +  /// Maps from indices to unnamed global values and metadata nodes.<br>
> +  const SlotMapping &LLVMModuleMapping;<br>
<br>
Everything here is LLVM, so this is a bit confusing; so is the word<br>
Module here.  What you're really talking about is a mapping at the<br>
IR-level (as opposed to the MIR-level, or the MC-level).<br>
<br>
I suggest "IRSlots".  (For consistency, you could (in a separate commit)<br>
change "MBBMapping" to "MBBSlots" ("mapping" doesn't really tell you<br>
anything about the key or the value; could also just be "MBBs").)<br>
<br>
LGTM after that.<br>
<br>
</blockquote></div><br></div>