<p dir="ltr">Alexey, wdyt about this functionality in general? Shall we limit it to TSan?</p>
<p dir="ltr">sent from phone</p>
<div class="gmail_quote">On Jun 24, 2015 8:30 PM, "Alexey Samsonov" <<a href="mailto:vonosmas@gmail.com">vonosmas@gmail.com</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">================<br>
Comment at: lib/tsan/rtl/tsan_suppressions.cc:110<br>
@@ -108,3 +109,3 @@<br>
     const AddressInfo &info = frame->info;<br>
     if (suppression_ctx->Match(info.function, stype, &s) ||<br>
         suppression_ctx->Match(info.file, stype, &s) ||<br>
----------------<br>
you can totally factor this out to<br>
  bool IsSuppressed(const AddressInfo &info, const char *suppression_type, Suppression **sp);<br>
<br>
================<br>
Comment at: lib/tsan/rtl/tsan_suppressions.cc:119<br>
@@ -117,1 +118,3 @@<br>
   }<br>
+  if (0 == internal_strcmp(stype, kSuppressionRace) && stack->frames != 0) {<br>
+    const AddressInfo &info = stack->frames->info;<br>
----------------<br>
  stack->frames != nullptr<br>
<br>
================<br>
Comment at: test/tsan/race_top_suppression.cc.supp:1<br>
@@ +1,1 @@<br>
+race_top:TopFunction<br>
----------------<br>
I'd prefer to get rid of extra file, and create it with "echo" command in the RUN-line.<br>
<br>
================<br>
Comment at: test/tsan/race_top_suppression1.cc.supp:1<br>
@@ +1,1 @@<br>
+race_top:TopFunction<br>
----------------<br>
Ditto<br>
<br>
<a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_D10686&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=ov_cNocb55SDBYg_7_QSHt99sR6oNt_BNqIeayKSvpM&s=qEibLcG7EQHJ_-SRZwq49p6G-x91AD2x2R2siynjVOI&e=" rel="noreferrer" target="_blank">http://reviews.llvm.org/D10686</a><br>
<br>
EMAIL PREFERENCES<br>
  <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_settings_panel_emailpreferences_&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=ov_cNocb55SDBYg_7_QSHt99sR6oNt_BNqIeayKSvpM&s=WccXUg23NObVYeY2Rj_XklgymWPAu5cNEery_y-Xr1E&e=" rel="noreferrer" target="_blank">http://reviews.llvm.org/settings/panel/emailpreferences/</a><br>
<br>
<br>
</blockquote></div>