<div dir="ltr">Note that we have REQUIRES clauses available for configured targets....</div><br><div class="gmail_quote"><div dir="ltr">On Mon, Jun 22, 2015 at 11:57 PM Justin Bogner <<a href="mailto:mail@justinbogner.com">mail@justinbogner.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">deadal nix <<a href="mailto:deadalnix@gmail.com" target="_blank">deadalnix@gmail.com</a>> writes:<br>
> The patch from git format patch.<br>
<br>
LGTM. Committed for you in r240380. Thanks!<br>
<br>
> 2015-06-22 23:34 GMT-07:00 Amaury SECHET <<a href="mailto:deadalnix%2Bllvmreview@gmail.com" target="_blank">deadalnix+llvmreview@gmail.com</a>>:<br>
><br>
> Hi bogner, chandlerc,<br>
><br>
> Dissasembly tests depends on target. The problem is that it disable all<br>
> tests if all targets are not compiled. This dif moves things around in<br>
> order to get target specific code in a target specific folder.<br>
><br>
> <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_D10636&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=-_LBFcVLDMBWUE_ZF6UXeVgGzUVXFYXB8aK3SaLuCF0&s=ABbMibiRzIH-JC8A1TpO2gmNOT4UYsTqLSDqA66lv0k&e=" rel="noreferrer" target="_blank">http://reviews.llvm.org/D10636</a><br>
><br>
> Files:<br>
> test/Bindings/llvm-c/ARM/disassemble.test<br>
> test/Bindings/llvm-c/ARM/lit.local.cfg<br>
> test/Bindings/llvm-c/X86/disassemble.test<br>
> test/Bindings/llvm-c/X86/lit.local.cfg<br>
> test/Bindings/llvm-c/disassemble.test<br>
> test/Bindings/llvm-c/lit.local.cfg<br>
><br>
> Index: test/Bindings/llvm-c/ARM/disassemble.test<br>
> ===================================================================<br>
> --- test/Bindings/llvm-c/ARM/disassemble.test<br>
> +++ test/Bindings/llvm-c/ARM/disassemble.test<br>
> @@ -19,25 +19,3 @@<br>
> ;CHECK: sub r1, r11, #12<br>
> ;CHECK: 02 20 81 e0<br>
> ;CHECK: add r2, r1, r2<br>
> -<br>
> -x86_64-linux-unknown NULL 48 83 c4 38 5b 5d 41 5c 41 5d 41 5e 41 5f c3<br>
> -;CHECK: triple: x86_64-linux-unknown, features: NULL<br>
> -;CHECK: addq $56, %rsp<br>
> -;CHECK: popq %rbx<br>
> -;CHECK: popq %rbp<br>
> -;CHECK: popq %r12<br>
> -;CHECK: popq %r13<br>
> -;CHECK: popq %r14<br>
> -;CHECK: popq %r15<br>
> -;CHECK: ret<br>
> -<br>
> -i686-apple-darwin NULL 0f b7 4c 24 0a e8 29 ce ff ff<br>
> -;CHECK: triple: i686-apple-darwin, features: NULL<br>
> -;CHECK: movzwl 10(%esp), %ecx<br>
> -;CHECK: calll -12759<br>
> -<br>
> -i686-linux-unknown NULL dd 44 24 04 d9 e1 c3<br>
> -;CHECK: triple: i686-linux-unknown, features: NULL<br>
> -;CHECK: fldl 4(%esp)<br>
> -;CHECK: fabs<br>
> -;CHECK: ret<br>
> Index: test/Bindings/llvm-c/ARM/lit.local.cfg<br>
> ===================================================================<br>
> --- test/Bindings/llvm-c/ARM/lit.local.cfg<br>
> +++ test/Bindings/llvm-c/ARM/lit.local.cfg<br>
> @@ -1,4 +1,2 @@<br>
> -if not "X86" in config.root.targets:<br>
> - config.unsupported = True<br>
> if not "ARM" in config.root.targets:<br>
> config.unsupported = True<br>
> Index: test/Bindings/llvm-c/X86/disassemble.test<br>
> ===================================================================<br>
> --- /dev/null<br>
> +++ test/Bindings/llvm-c/X86/disassemble.test<br>
> @@ -0,0 +1,23 @@<br>
> +; RUN: llvm-c-test --disassemble < %s | FileCheck %s<br>
> +<br>
> +x86_64-linux-unknown NULL 48 83 c4 38 5b 5d 41 5c 41 5d 41 5e 41 5f c3<br>
> +;CHECK: triple: x86_64-linux-unknown, features: NULL<br>
> +;CHECK: addq $56, %rsp<br>
> +;CHECK: popq %rbx<br>
> +;CHECK: popq %rbp<br>
> +;CHECK: popq %r12<br>
> +;CHECK: popq %r13<br>
> +;CHECK: popq %r14<br>
> +;CHECK: popq %r15<br>
> +;CHECK: ret<br>
> +<br>
> +i686-apple-darwin NULL 0f b7 4c 24 0a e8 29 ce ff ff<br>
> +;CHECK: triple: i686-apple-darwin, features: NULL<br>
> +;CHECK: movzwl 10(%esp), %ecx<br>
> +;CHECK: calll -12759<br>
> +<br>
> +i686-linux-unknown NULL dd 44 24 04 d9 e1 c3<br>
> +;CHECK: triple: i686-linux-unknown, features: NULL<br>
> +;CHECK: fldl 4(%esp)<br>
> +;CHECK: fabs<br>
> +;CHECK: ret<br>
> Index: test/Bindings/llvm-c/X86/lit.local.cfg<br>
> ===================================================================<br>
> --- test/Bindings/llvm-c/X86/lit.local.cfg<br>
> +++ test/Bindings/llvm-c/X86/lit.local.cfg<br>
> @@ -1,4 +1,2 @@<br>
> if not "X86" in config.root.targets:<br>
> config.unsupported = True<br>
> -if not "ARM" in config.root.targets:<br>
> - config.unsupported = True<br>
><br>
> EMAIL PREFERENCES<br>
> <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_settings_panel_emailpreferences_&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=-_LBFcVLDMBWUE_ZF6UXeVgGzUVXFYXB8aK3SaLuCF0&s=CGuGpr2BYpUJDTTJD1R4XJE9ZZXEwXc3_TzqD6j_-pk&e=" rel="noreferrer" target="_blank">http://reviews.llvm.org/settings/panel/emailpreferences/</a><br>
><br>
> From 48aa3657f30d8bac3030a79d153fc94d9a90f5b2 Mon Sep 17 00:00:00 2001<br>
> From: amaury <<a href="mailto:amaury@fb.com" target="_blank">amaury@fb.com</a>><br>
> Date: Mon, 22 Jun 2015 23:23:19 -0700<br>
> Subject: [PATCH] Move target dependent test in their own folder for c API test<br>
><br>
> Summary: Dissasembly tests depends on target. The problem is that it disable all tests if all targets are not compiled. This dif moves things around in order to get target specific code in a target specific folder.<br>
><br>
> Test Plan:<br>
> bin/llvm-lit ../test/Bindings/llvm-c<br>
><br>
> Reviewers: bogner, chandlerc<br>
><br>
> Subscribers: llvm-commits<br>
><br>
> Differential Revision: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_D10636&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=-_LBFcVLDMBWUE_ZF6UXeVgGzUVXFYXB8aK3SaLuCF0&s=ABbMibiRzIH-JC8A1TpO2gmNOT4UYsTqLSDqA66lv0k&e=" rel="noreferrer" target="_blank">http://reviews.llvm.org/D10636</a><br>
> ---<br>
> test/Bindings/llvm-c/ARM/disassemble.test | 21 +++++++++++++++<br>
> test/Bindings/llvm-c/ARM/lit.local.cfg | 2 ++<br>
> test/Bindings/llvm-c/X86/disassemble.test | 23 +++++++++++++++++<br>
> test/Bindings/llvm-c/X86/lit.local.cfg | 2 ++<br>
> test/Bindings/llvm-c/disassemble.test | 43 -------------------------------<br>
> test/Bindings/llvm-c/lit.local.cfg | 4 ---<br>
> 6 files changed, 48 insertions(+), 47 deletions(-)<br>
> create mode 100644 test/Bindings/llvm-c/ARM/disassemble.test<br>
> create mode 100644 test/Bindings/llvm-c/ARM/lit.local.cfg<br>
> create mode 100644 test/Bindings/llvm-c/X86/disassemble.test<br>
> create mode 100644 test/Bindings/llvm-c/X86/lit.local.cfg<br>
> delete mode 100644 test/Bindings/llvm-c/disassemble.test<br>
> delete mode 100644 test/Bindings/llvm-c/lit.local.cfg<br>
><br>
> diff --git a/test/Bindings/llvm-c/ARM/disassemble.test b/test/Bindings/llvm-c/ARM/disassemble.test<br>
> new file mode 100644<br>
> index 0000000..ffa7ebf<br>
> --- /dev/null<br>
> +++ b/test/Bindings/llvm-c/ARM/disassemble.test<br>
> @@ -0,0 +1,21 @@<br>
> +; RUN: llvm-c-test --disassemble < %s | FileCheck %s<br>
> +<br>
> +armv8-linux-gnu +crypto 02 00 81 e0 02 03 b0 f3<br>
> +;CHECK: triple: armv8-linux-gnu, features: +crypto<br>
> +;CHECK: 02 00 81 e0 add r0, r1, r2<br>
> +;CHECK: 02 03 b0 f3 aese.8 q0, q1<br>
> +<br>
> +armv8-linux-gnu -crypto 02 00 81 e0 02 03 b0 f3<br>
> +;CHECK: triple: armv8-linux-gnu, features: -crypto<br>
> +;CHECK: 02 00 81 e0 add r0, r1, r2<br>
> +;CHECK: 02 ???<br>
> +;CHECK: 03 ???<br>
> +;CHECK: b0 ???<br>
> +;CHECK: f3 ???<br>
> +<br>
> +arm-linux-android NULL 44 26 1f e5 0c 10 4b e2 02 20 81 e0<br>
> +;CHECK: triple: arm-linux-android, features: NULL<br>
> +;CHECK: ldr r2, [pc, #-1604]<br>
> +;CHECK: sub r1, r11, #12<br>
> +;CHECK: 02 20 81 e0<br>
> +;CHECK: add r2, r1, r2<br>
> diff --git a/test/Bindings/llvm-c/ARM/lit.local.cfg b/test/Bindings/llvm-c/ARM/lit.local.cfg<br>
> new file mode 100644<br>
> index 0000000..7c23e4f<br>
> --- /dev/null<br>
> +++ b/test/Bindings/llvm-c/ARM/lit.local.cfg<br>
> @@ -0,0 +1,2 @@<br>
> +if not "ARM" in config.root.targets:<br>
> + config.unsupported = True<br>
> diff --git a/test/Bindings/llvm-c/X86/disassemble.test b/test/Bindings/llvm-c/X86/disassemble.test<br>
> new file mode 100644<br>
> index 0000000..465b370<br>
> --- /dev/null<br>
> +++ b/test/Bindings/llvm-c/X86/disassemble.test<br>
> @@ -0,0 +1,23 @@<br>
> +; RUN: llvm-c-test --disassemble < %s | FileCheck %s<br>
> +<br>
> +x86_64-linux-unknown NULL 48 83 c4 38 5b 5d 41 5c 41 5d 41 5e 41 5f c3<br>
> +;CHECK: triple: x86_64-linux-unknown, features: NULL<br>
> +;CHECK: addq $56, %rsp<br>
> +;CHECK: popq %rbx<br>
> +;CHECK: popq %rbp<br>
> +;CHECK: popq %r12<br>
> +;CHECK: popq %r13<br>
> +;CHECK: popq %r14<br>
> +;CHECK: popq %r15<br>
> +;CHECK: ret<br>
> +<br>
> +i686-apple-darwin NULL 0f b7 4c 24 0a e8 29 ce ff ff<br>
> +;CHECK: triple: i686-apple-darwin, features: NULL<br>
> +;CHECK: movzwl 10(%esp), %ecx<br>
> +;CHECK: calll -12759<br>
> +<br>
> +i686-linux-unknown NULL dd 44 24 04 d9 e1 c3<br>
> +;CHECK: triple: i686-linux-unknown, features: NULL<br>
> +;CHECK: fldl 4(%esp)<br>
> +;CHECK: fabs<br>
> +;CHECK: ret<br>
> diff --git a/test/Bindings/llvm-c/X86/lit.local.cfg b/test/Bindings/llvm-c/X86/lit.local.cfg<br>
> new file mode 100644<br>
> index 0000000..42bf50d<br>
> --- /dev/null<br>
> +++ b/test/Bindings/llvm-c/X86/lit.local.cfg<br>
> @@ -0,0 +1,2 @@<br>
> +if not "X86" in config.root.targets:<br>
> + config.unsupported = True<br>
> diff --git a/test/Bindings/llvm-c/disassemble.test b/test/Bindings/llvm-c/disassemble.test<br>
> deleted file mode 100644<br>
> index bb7a9a0..0000000<br>
> --- a/test/Bindings/llvm-c/disassemble.test<br>
> +++ /dev/null<br>
> @@ -1,43 +0,0 @@<br>
> -; RUN: llvm-c-test --disassemble < %s | FileCheck %s<br>
> -<br>
> -armv8-linux-gnu +crypto 02 00 81 e0 02 03 b0 f3<br>
> -;CHECK: triple: armv8-linux-gnu, features: +crypto<br>
> -;CHECK: 02 00 81 e0 add r0, r1, r2<br>
> -;CHECK: 02 03 b0 f3 aese.8 q0, q1<br>
> -<br>
> -armv8-linux-gnu -crypto 02 00 81 e0 02 03 b0 f3<br>
> -;CHECK: triple: armv8-linux-gnu, features: -crypto<br>
> -;CHECK: 02 00 81 e0 add r0, r1, r2<br>
> -;CHECK: 02 ???<br>
> -;CHECK: 03 ???<br>
> -;CHECK: b0 ???<br>
> -;CHECK: f3 ???<br>
> -<br>
> -arm-linux-android NULL 44 26 1f e5 0c 10 4b e2 02 20 81 e0<br>
> -;CHECK: triple: arm-linux-android, features: NULL<br>
> -;CHECK: ldr r2, [pc, #-1604]<br>
> -;CHECK: sub r1, r11, #12<br>
> -;CHECK: 02 20 81 e0<br>
> -;CHECK: add r2, r1, r2<br>
> -<br>
> -x86_64-linux-unknown NULL 48 83 c4 38 5b 5d 41 5c 41 5d 41 5e 41 5f c3<br>
> -;CHECK: triple: x86_64-linux-unknown, features: NULL<br>
> -;CHECK: addq $56, %rsp<br>
> -;CHECK: popq %rbx<br>
> -;CHECK: popq %rbp<br>
> -;CHECK: popq %r12<br>
> -;CHECK: popq %r13<br>
> -;CHECK: popq %r14<br>
> -;CHECK: popq %r15<br>
> -;CHECK: ret<br>
> -<br>
> -i686-apple-darwin NULL 0f b7 4c 24 0a e8 29 ce ff ff<br>
> -;CHECK: triple: i686-apple-darwin, features: NULL<br>
> -;CHECK: movzwl 10(%esp), %ecx<br>
> -;CHECK: calll -12759<br>
> -<br>
> -i686-linux-unknown NULL dd 44 24 04 d9 e1 c3<br>
> -;CHECK: triple: i686-linux-unknown, features: NULL<br>
> -;CHECK: fldl 4(%esp)<br>
> -;CHECK: fabs<br>
> -;CHECK: ret<br>
> diff --git a/test/Bindings/llvm-c/lit.local.cfg b/test/Bindings/llvm-c/lit.local.cfg<br>
> deleted file mode 100644<br>
> index 75b22c0..0000000<br>
> --- a/test/Bindings/llvm-c/lit.local.cfg<br>
> +++ /dev/null<br>
> @@ -1,4 +0,0 @@<br>
> -if not "X86" in config.root.targets:<br>
> - config.unsupported = True<br>
> -if not "ARM" in config.root.targets:<br>
> - config.unsupported = True<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>