<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
This is very unlikely to ever be accepted. In particular, I know of
several long standing developers who use in tree builds.<br>
<br>
Do you have a good *reason* (other than merely best practice) why
this needs to be changed?<br>
<br>
Philip<br>
<br>
<div class="moz-cite-prefix">On 06/22/2015 01:46 PM, Jonathan
Roelofs wrote:<br>
</div>
<blockquote
cite="mid:differential-rev-PHID-DREV-w5w7zlqofillv5abna7i-req@reviews.llvm.org"
type="cite">
<pre wrap="">Context: <a class="moz-txt-link-freetext" href="http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20150323/268067.html">http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20150323/268067.html</a>
<a class="moz-txt-link-freetext" href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_D10614&d=AwMD-g&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=uCriU_Mx8Xj4MSKqR4hPSAO7o0t8jIgYxj72IjPpX3E&s=X2WnUYg1uPkKdpB1DQ0mbzcEwGafALAB0EzQhAOcHSo&e=">http://reviews.llvm.org/D10614</a>
Files:
Makefile.config.in
autoconf/configure.ac
configure
Index: Makefile.config.in
===================================================================
--- Makefile.config.in
+++ Makefile.config.in
@@ -58,20 +58,9 @@
PROJ_SRC_ROOT := $(LLVM_SRC_ROOT)
PROJ_SRC_DIR := $(LLVM_SRC_ROOT)$(patsubst $(PROJ_OBJ_ROOT)%,%,$(PROJ_OBJ_DIR))
-# FIXME: This is temporary during the grace period where in-source builds are
-# deprecated. Convert to a hard error when that period is up.
-#
# See: <a class="moz-txt-link-freetext" href="http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20150323/268067.html">http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20150323/268067.html</a>
ifeq ($(LLVM_SRC_ROOT), $(LLVM_OBJ_ROOT))
- $(warning ######################################################################################)
- $(warning # #)
- $(warning # WARNING #)
- $(warning # #)
- $(warning # In-source builds are deprecated. #)
- $(warning # #)
- $(warning # Please configure from a separate build directory! #)
- $(warning # #)
- $(warning ######################################################################################)
+ $(error In-source builds are not allowed. Please configure from a separate build directory!)
endif
ifneq ($(CLANG_SRC_ROOT),)
Index: autoconf/configure.ac
===================================================================
--- autoconf/configure.ac
+++ autoconf/configure.ac
@@ -75,15 +75,7 @@
dnl Quit if it is an in-source build
if test ${srcdir} == "." ; then
- AC_MSG_WARN([**************************************************************************************])
- AC_MSG_WARN([* *])
- AC_MSG_WARN([* WARNING *])
- AC_MSG_WARN([* *])
- AC_MSG_WARN([* In-source builds are deprecated. *])
- AC_MSG_WARN([* *])
- AC_MSG_WARN([* Please configure from a separate build directory! *])
- AC_MSG_WARN([* *])
- AC_MSG_WARN([**************************************************************************************])
+ AC_MSG_ERROR([In-source builds are not allowed. Please configure from a separate build directory!])
fi
dnl Default to empty (i.e. assigning the null string to) CFLAGS and CXXFLAGS,
Index: configure
===================================================================
--- configure
+++ configure
@@ -2033,24 +2033,9 @@
fi
if test ${srcdir} == "." ; then
- { echo "$as_me:$LINENO: WARNING: **************************************************************************************" >&5
-echo "$as_me: WARNING: **************************************************************************************" >&2;}
- { echo "$as_me:$LINENO: WARNING: * *" >&5
-echo "$as_me: WARNING: * *" >&2;}
- { echo "$as_me:$LINENO: WARNING: * WARNING *" >&5
-echo "$as_me: WARNING: * WARNING *" >&2;}
- { echo "$as_me:$LINENO: WARNING: * *" >&5
-echo "$as_me: WARNING: * *" >&2;}
- { echo "$as_me:$LINENO: WARNING: * In-source builds are deprecated. *" >&5
-echo "$as_me: WARNING: * In-source builds are deprecated. *" >&2;}
- { echo "$as_me:$LINENO: WARNING: * *" >&5
-echo "$as_me: WARNING: * *" >&2;}
- { echo "$as_me:$LINENO: WARNING: * Please configure from a separate build directory! *" >&5
-echo "$as_me: WARNING: * Please configure from a separate build directory! *" >&2;}
- { echo "$as_me:$LINENO: WARNING: * *" >&5
-echo "$as_me: WARNING: * *" >&2;}
- { echo "$as_me:$LINENO: WARNING: **************************************************************************************" >&5
-echo "$as_me: WARNING: **************************************************************************************" >&2;}
+ { { echo "$as_me:$LINENO: error: In-source builds are not allowed. Please configure from a separate build directory!" >&5
+echo "$as_me: error: In-source builds are not allowed. Please configure from a separate build directory!" >&2;}
+ { (exit 1); exit 1; }; }
fi
: ${CFLAGS=}
EMAIL PREFERENCES
<a class="moz-txt-link-freetext" href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_settings_panel_emailpreferences_&d=AwMD-g&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=uCriU_Mx8Xj4MSKqR4hPSAO7o0t8jIgYxj72IjPpX3E&s=-PBCEvOy4KUOuAk0HAIq8Hhn-eddsizmaS9DcHUzJ7E&e=">http://reviews.llvm.org/settings/panel/emailpreferences/</a>
</pre>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
llvm-commits mailing list
<a class="moz-txt-link-abbreviated" href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a>
<a class="moz-txt-link-freetext" href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a>
</pre>
</blockquote>
<br>
</body>
</html>