<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Jun 22, 2015, at 1:57 PM, Paweł Bylica <<a href="mailto:chfast@gmail.com" class="">chfast@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">I'm about to send a change that will fix the regression test (it should be -march=x86). It should fix build failures like:<div class=""><a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__lab.llvm.org-3A8011_builders_llvm-2Ds390x-2Dlinux1_builds_16458&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=Vny-_yn4CKE2JrxriqCsJL_lT3VEeeS6boqb7DH3xa8&s=arBGZ7kOUdFc2kYNE5aqthdUpQRr8NwxEbx15zIjXL8&e=" class="">http://lab.llvm.org:8011/builders/llvm-s390x-linux1/builds/16458</a><br class=""></div><div class=""><br class=""></div><div class="">However your is similar to that one:<br class=""><div class=""><a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__lab.llvm.org-3A8011_builders_clang-2Dx86-5F64-2Dlinux-2Dselfhost-2Dabi-2Dtest_builds_5852&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=Vny-_yn4CKE2JrxriqCsJL_lT3VEeeS6boqb7DH3xa8&s=d23cK-XgHB_zQ-W1NTWqBs7bueVV1C6vRUjOGQzirUg&e=" class="">http://lab.llvm.org:8011/builders/clang-x86_64-linux-selfhost-abi-test/builds/5852</a><br class=""></div><div class="">but I'm not sure what's wrong with that.</div><div class=""><br class=""></div><div class="">Give me 10 more minutes. If it will not help, please revert it.</div></div></div></div></blockquote><div><br class=""></div><div>I just saw your commit. I think there is no way that your fix in the test could fix any of the self host issues (the green dragon failure is a self-hosted LTO build and the other failing bot you pointed me at is also a self-host). Are you investigating the other failures? The 2 failing bots have only your commit in common in their blame lists so at this point it’s pretty clear that this commit triggers something very wrong in a clang self-host build. It should be pretty easy to reproduce. I’d appreciate if you revert this change so that the bots can become green again. </div><div><br class=""></div><div>Fred </div><br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""><div class=""><div class="">- Paweł</div><div class=""><br class=""></div><div class=""><br class=""></div></div></div><br class=""><div class="gmail_quote"><div dir="ltr" class="">On Mon, Jun 22, 2015 at 10:47 PM Frédéric Riss <<a href="mailto:friss@apple.com" class="">friss@apple.com</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word" class=""><div class="">This commit is by far the most likely culprit for the hangs we see on green dragon:</div><div class=""><a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__lab.llvm.org-3A8080_green_job_clang-2Dstage2-2Dconfigure-2DRlto-5Fcheck_&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=Vny-_yn4CKE2JrxriqCsJL_lT3VEeeS6boqb7DH3xa8&s=tWMO1ypOV7RKWFajTBGQuGfUBjCD_OSWZMll0k17txk&e=" target="_blank" class="">http://lab.llvm.org:8080/green/job/clang-stage2-configure-Rlto_check/</a></div><div class=""><br class=""></div><div class="">Did you have any other failures? Would you mind reverting it to see if it fixes things? (This is after an LTO bootstrap, so it takes quite some time to reproduce/propagate).</div><div class=""><br class=""></div><div class="">Fred</div></div><div style="word-wrap:break-word" class=""><br class=""><div class=""><blockquote type="cite" class=""><div class="">On Jun 22, 2015, at 8:58 AM, Pawel Bylica <<a href="mailto:chfast@gmail.com" target="_blank" class="">chfast@gmail.com</a>> wrote:</div><br class=""><div class=""><div class="">Author: chfast<br class="">Date: Mon Jun 22 10:58:11 2015<br class="">New Revision: 240291<br class=""><br class="">URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject-3Frev-3D240291-26view-3Drev&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=Vny-_yn4CKE2JrxriqCsJL_lT3VEeeS6boqb7DH3xa8&s=nLPGIkqSoSoEjRIcSb1G5sOAVN3YWkEk0BvNGOrm4JM&e=" target="_blank" class="">http://llvm.org/viewvc/llvm-project?rev=240291&view=rev</a><br class="">Log:<br class="">Fix shl folding in DAG combiner.<br class=""><br class="">Summary: The code responsible for shl folding in the DAGCombiner was assuming incorrectly that all constants are less than 64 bits. This patch simply changes the way values are compared.<br class=""><br class="">Test Plan: A regression test included.<br class=""><br class="">Reviewers: andreadb<br class=""><br class="">Reviewed By: andreadb<br class=""><br class="">Subscribers: andreadb, test, llvm-commits<br class=""><br class="">Differential Revision: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_D10602&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=Vny-_yn4CKE2JrxriqCsJL_lT3VEeeS6boqb7DH3xa8&s=UZbdp0oEwEV38tiFCV7iMp78M9zdoUgMxlqJM8QPBlo&e=" target="_blank" class="">http://reviews.llvm.org/D10602</a><br class=""><br class="">Added:<br class=""> llvm/trunk/test/CodeGen/X86/fold-vector-shl-crash.ll<br class="">Modified:<br class=""> llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp<br class=""><br class="">Modified: llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp<br class="">URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_llvm_trunk_lib_CodeGen_SelectionDAG_DAGCombiner.cpp-3Frev-3D240291-26r1-3D240290-26r2-3D240291-26view-3Ddiff&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=Vny-_yn4CKE2JrxriqCsJL_lT3VEeeS6boqb7DH3xa8&s=KRn9eBnUL2COWwqRN6QwJEKMTUlceF1lHl-tJenSlj4&e=" target="_blank" class="">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp?rev=240291&r1=240290&r2=240291&view=diff</a><br class="">==============================================================================<br class="">--- llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp (original)<br class="">+++ llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp Mon Jun 22 10:58:11 2015<br class="">@@ -4275,7 +4275,7 @@ SDValue DAGCombiner::visitSHL(SDNode *N)<br class=""> if (isNullConstant(N0))<br class=""> return N0;<br class=""> // fold (shl x, c >= size(x)) -> undef<br class="">- if (N1C && N1C->getZExtValue() >= OpSizeInBits)<br class="">+ if (N1C && N1C->getAPIntValue().uge(OpSizeInBits))<br class=""> return DAG.getUNDEF(VT);<br class=""> // fold (shl x, 0) -> x<br class=""> if (N1C && N1C->isNullValue())<br class=""><br class="">Added: llvm/trunk/test/CodeGen/X86/fold-vector-shl-crash.ll<br class="">URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_llvm_trunk_test_CodeGen_X86_fold-2Dvector-2Dshl-2Dcrash.ll-3Frev-3D240291-26view-3Dauto&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=Vny-_yn4CKE2JrxriqCsJL_lT3VEeeS6boqb7DH3xa8&s=cwDCkbyvLhLzYPaNk9HmyJ9-Te9nfuO871KWhK_8yHY&e=" target="_blank" class="">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/fold-vector-shl-crash.ll?rev=240291&view=auto</a><br class="">==============================================================================<br class="">--- llvm/trunk/test/CodeGen/X86/fold-vector-shl-crash.ll (added)<br class="">+++ llvm/trunk/test/CodeGen/X86/fold-vector-shl-crash.ll Mon Jun 22 10:58:11 2015<br class="">@@ -0,0 +1,8 @@<br class="">+; RUN: llc < %s | FileCheck %s<br class="">+<br class="">+;CHECK-LABEL: test<br class="">+define <2 x i256> @test() {<br class="">+ %S = shufflevector <2 x i256> zeroinitializer, <2 x i256> <i256 -1, i256 -1>, <2 x i32> <i32 0, i32 2><br class="">+ %B = shl <2 x i256> %S, <i256 -1, i256 -1> ; DAG Combiner crashes here<br class="">+ ret <2 x i256> %B<br class="">+}<br class=""><br class=""><br class="">_______________________________________________<br class="">llvm-commits mailing list<br class=""><a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank" class="">llvm-commits@cs.uiuc.edu</a><br class=""><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank" class="">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br class=""></div></div></blockquote></div><br class=""></div></blockquote></div>
</div></blockquote></div><br class=""></body></html>