<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Jun 22, 2015 at 12:14 PM, Krzysztof Parzyszek <span dir="ltr"><<a href="mailto:kparzysz@codeaurora.org" target="_blank">kparzysz@codeaurora.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Because the subclasses of VLIWPacketizerList can modify the machine function.  With this change they can use the MF member from the parent class.<br></blockquote><div><br>Might've been helpful to include all/some such changes in the patch to demonstrate the motivation for the change.<br><br>- David<br> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
-Krzysztof<span class=""><br>
<br>
<br>
On 6/22/2015 2:13 PM, Eric Christopher wrote:<br>
</span><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">
... why?<br>
<br>
-eric<br>
<br>
On Mon, Jun 22, 2015 at 12:06 PM Krzysztof Parzyszek<br></span><div><div class="h5">
<<a href="mailto:kparzysz@codeaurora.org" target="_blank">kparzysz@codeaurora.org</a> <mailto:<a href="mailto:kparzysz@codeaurora.org" target="_blank">kparzysz@codeaurora.org</a>>> wrote:<br>
<br>
    Author: kparzysz<br>
    Date: Mon Jun 22 13:59:44 2015<br>
    New Revision: 240317<br>
<br>
    URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject-3Frev-3D240317-26view-3Drev&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=kL2_O0GjBwcpyB5EZ97ViFXBN-4O6C39EoclXJc-Bjo&s=StNyFJnmSo8IEiN7hSjNBNTLkWPBu0h0_rvRLnyfnGo&e=" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=240317&view=rev</a><br>
    Log:<br>
    Remove "const" from the MachineFunction reference in VLIWPacketizerList<br>
<br>
<br>
    Modified:<br>
         llvm/trunk/include/llvm/CodeGen/DFAPacketizer.h<br>
<br>
    Modified: llvm/trunk/include/llvm/CodeGen/DFAPacketizer.h<br>
    URL:<br>
    <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_llvm_trunk_include_llvm_CodeGen_DFAPacketizer.h-3Frev-3D240317-26r1-3D240316-26r2-3D240317-26view-3Ddiff&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=kL2_O0GjBwcpyB5EZ97ViFXBN-4O6C39EoclXJc-Bjo&s=kFNwJuWtcxRj8Os8dz9NM9Qfel388flaGuVTOKRMMa0&e=" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/CodeGen/DFAPacketizer.h?rev=240317&r1=240316&r2=240317&view=diff</a><br>
    ==============================================================================<br>
    --- llvm/trunk/include/llvm/CodeGen/DFAPacketizer.h (original)<br>
    +++ llvm/trunk/include/llvm/CodeGen/DFAPacketizer.h Mon Jun 22<br>
    13:59:44 2015<br>
    @@ -91,7 +91,7 @@ public:<br>
      // API call is made to prune the dependence.<br>
      class VLIWPacketizerList {<br>
      protected:<br>
    -  const MachineFunction &MF;<br>
    +  MachineFunction &MF;<br>
        const TargetInstrInfo *TII;<br>
<br>
        // The VLIW Scheduler.<br>
<br>
<br>
    _______________________________________________<br>
    llvm-commits mailing list<br></div></div>
    <a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a> <mailto:<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a>><br>
    <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
<br><span class="HOEnZb"><font color="#888888">
</font></span></blockquote><span class="HOEnZb"><font color="#888888">
<br>
<br>
-- <br>
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation</font></span><div class="HOEnZb"><div class="h5"><br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</div></div></blockquote></div><br></div></div>