<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">2015-06-17 13:52 GMT-07:00 Duncan P. N. Exon Smith <span dir="ltr"><<a href="mailto:dexonsmith@apple.com" target="_blank">dexonsmith@apple.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class=""><br>
> On 2015 Jun 17, at 13:20, Alex Lorenz <<a href="mailto:arphaman@gmail.com">arphaman@gmail.com</a>> wrote:<br>
><br>
> Hi dexonsmith, bob.wilson, bogner,<br>
><br>
> This patch moves the SlotTracker class out of AsmWriter.cpp into a separate module that's publicly accessible.<br>
><br>
> This patch would be useful for MIR Serialization, in particular it would enable the MIR parser to parse metadata machine operands. The metadata machine operands are serialized using the familiar '!' <slot> notation, and the MIR parser has to be able to map from slot numbers to the actual metadata nodes. The SlotTracker class would allow the MIRParser to create this mapping.<br>
<br>
</span>I can see that this would be useful for *writing* .mir files, but I<br>
don't think you can safely use this for *reading* .mir files.<br>
<br>
Metadata slots can be assigned arbitrarily in an LLVM IR file, such as:<br>
<br>
!named = !{!36, !72}<br>
!72 = !{!"string"}}<br>
!36 = !{!72, !{!{}}}<br>
<br>
If you were to parse the module and then run the slot tracker, you'd get:<br>
<br>
!named = !{!1, !2}<br>
!1 = !{!2, !3}<br>
!2 = !{!"string"}<br>
!3 = !{!4}<br>
!4 = !{}<br>
<br>
or something close to that.<br>
<br>
You couldn't safely take an already-parsed Module, run the slot-tracker<br>
on it, and then parse machine functions that referenced metadata. But<br>
it sounds like that's what you're suggesting?<br></blockquote><div><br></div><div>This makes sense, yeah this patch wouldn't really work then.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Instead, I think you need to:<br>
<br>
1. Yes, surface the slot tracker (exactly this patch), but for completely<br>
different reasons: so that you can write out correct metadata numbers<br>
for metadata references within machine functions, to match the metadata<br>
that you wrote out for the LLVM IR.<br>
2. Use (1) so that the same slots are used when writing LLVM IR portion of<br>
MIR as the machine functions.<br></blockquote><div><br></div><div>I don't need to surface the slot tracker then, as I can print out the correct metadata slot numbers by printing the metadata nodes as operands. They create the slot tracker and initialize it for the whole module, so the correct slot numbers are printed.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
3. Find a way to surface `LLParser::NumberedMetadata` in a similar way<br>
(could be some way of copying them out?) when parsing the LLVM IR part<br>
of MIR.<br>
4. Use that slot mapping when you're reading machine functions.<br></blockquote><div><br></div><div>Yeah, I should surface the slot mapping from the LLParser then. </div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Also, I'm not sure this just affects metadata. What about llvm::Type?<br>
llvm::GlobalValue? (Maybe their numbered slots are more strictly organized<br>
so they're okay, but I'm not sure.)<br></blockquote><div><br></div><div>I'm not sure yet, but I don't think they're affected in the same manner. The only other things that I can think of are some of the LLVM IR references that I serialize - like the allocas, and memory operand values, as they can be numbered, and their numbering can be different when parsing and printing. I will have to surface the mappings for those things as well.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Does this make sense?<br>
<span class=""><br>
><br>
> REPOSITORY<br>
> rL LLVM<br>
><br>
> <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_D10517&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=iXWMfH7XfxC5gFJQYcmVHcNx4_jYxPDAKDg8tAdvrAo&s=fxCNs6hdLq51pWCbrnNXiOtncoLUwBWPxnUZVuUg1AA&e=" rel="noreferrer" target="_blank">http://reviews.llvm.org/D10517</a><br>
><br>
> Files:<br>
> include/llvm/IR/SlotTracker.h<br>
> lib/IR/AsmWriter.cpp<br>
> lib/IR/CMakeLists.txt<br>
> lib/IR/SlotTracker.cpp<br>
><br>
> EMAIL PREFERENCES<br>
> <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_settings_panel_emailpreferences_&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=iXWMfH7XfxC5gFJQYcmVHcNx4_jYxPDAKDg8tAdvrAo&s=3W_PV7xTELIupvQjHQHzjMUZC2igvEPVnpiNwAyOShU&e=" rel="noreferrer" target="_blank">http://reviews.llvm.org/settings/panel/emailpreferences/</a><br>
</span>> <D10517.27862.patch><br>
<br>
</blockquote></div><br></div></div>