<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"><head><meta http-equiv=Content-Type content="text/html; charset=us-ascii"><meta name=Generator content="Microsoft Word 14 (filtered medium)"><!--[if !mso]><style>v\:* {behavior:url(#default#VML);}
o\:* {behavior:url(#default#VML);}
w\:* {behavior:url(#default#VML);}
.shape {behavior:url(#default#VML);}
</style><![endif]--><style><!--
/* Font Definitions */
@font-face
{font-family:Wingdings;
panose-1:5 0 0 0 0 0 0 0 0 0;}
@font-face
{font-family:Wingdings;
panose-1:5 0 0 0 0 0 0 0 0 0;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
@font-face
{font-family:"Lucida Sans Typewriter";
panose-1:2 11 5 9 3 5 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";
mso-fareast-language:EN-US;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p.MsoAcetate, li.MsoAcetate, div.MsoAcetate
{mso-style-priority:99;
mso-style-link:"Balloon Text Char";
margin:0cm;
margin-bottom:.0001pt;
font-size:8.0pt;
font-family:"Tahoma","sans-serif";
mso-fareast-language:EN-US;}
span.BalloonTextChar
{mso-style-name:"Balloon Text Char";
mso-style-priority:99;
mso-style-link:"Balloon Text";
font-family:"Tahoma","sans-serif";}
span.EmailStyle19
{mso-style-type:personal;
font-family:"Calibri","sans-serif";
color:windowtext;}
span.EmailStyle20
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]--></head><body lang=EN-GB link=blue vlink=purple><div class=WordSection1><p class=MsoNormal><span style='color:#1F497D'>Thanks for the quick review!<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal><span style='color:#1F497D'>Ah – didn’t know about the pep8 tool – that’s very useful indeed </span><span style='font-family:Wingdings;color:#1F497D'>J</span><span style='color:#1F497D'>.<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal><span style='color:#1F497D'>I’ve made those pep8 and number of columns fixes and committed this </span><span style='color:#1F497D'>as r</span><span style='color:#1F497D;mso-fareast-language:EN-GB'>239891</span><span style='color:#1F497D'>.<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal><span style='color:#1F497D'>Kristof<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'><o:p> </o:p></span></p><div style='border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt'><div><div style='border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0cm 0cm 0cm'><p class=MsoNormal><b><span lang=EN-US style='font-size:10.0pt;font-family:"Tahoma","sans-serif";mso-fareast-language:EN-GB'>From:</span></b><span lang=EN-US style='font-size:10.0pt;font-family:"Tahoma","sans-serif";mso-fareast-language:EN-GB'> Chris Matthews [mailto:chris.matthews@apple.com] <br><b>Sent:</b> 16 June 2015 20:22<br><b>To:</b> Kristof Beyls<br><b>Cc:</b> llvm-commits; James Molloy; Renato Golin; Tobias Grosser<br><b>Subject:</b> Re: [PATCH][LNT] Add sparklines to daily report page<o:p></o:p></span></p></div></div><p class=MsoNormal><o:p> </o:p></p><div><p class=MsoNormal>LGTM. A few nits:<o:p></o:p></p></div><div><p class=MsoNormal><o:p> </o:p></p></div><div><p class=MsoNormal>We are using PEP8 style in most files now. Grab the pep8 tool, it will do a good job picking out all the little things. That file was already clean.<o:p></o:p></p></div><div><p class=MsoNormal><o:p> </o:p></p></div><div><p class=MsoNormal>Can you make the table headings and benchmark name row the correct number of columns? The spark cell just hangs off the side (for me).<o:p></o:p></p></div><div><p class=MsoNormal><o:p> </o:p></p></div><p class=MsoNormal><img width=640 height=120 id="_x0034_987160C-BC7E-46A8-AA95-72937173064A" src="cid:image001.png@01D0A8E5.22934B80"><o:p></o:p></p><div><p class=MsoNormal><o:p> </o:p></p><div><blockquote style='margin-top:5.0pt;margin-bottom:5.0pt'><div><p class=MsoNormal>On Jun 16, 2015, at 10:08 AM, Kristof Beyls <<a href="mailto:kristof.beyls@arm.com">kristof.beyls@arm.com</a>> wrote:<o:p></o:p></p></div><p class=MsoNormal><o:p> </o:p></p><div><div><div><p class=MsoNormal>In the daily report table, performance differences are highlighted as a single percentage<o:p></o:p></p></div><div><p class=MsoNormal>difference. Due to the noise in many benchmarks and boards, often the true<o:p></o:p></p></div><div><p class=MsoNormal>performance characteristic cannot be summarized well into a single percentage<o:p></o:p></p></div><div><p class=MsoNormal>number, and a human has to look at all the samples/data points collected by the<o:p></o:p></p></div><div><p class=MsoNormal>benchmarking runs to make a further assessment of whether a performance change<o:p></o:p></p></div><div><p class=MsoNormal>should be categorized as "noise" or "real".<o:p></o:p></p></div><div><p class=MsoNormal> <o:p></o:p></p></div><div><p class=MsoNormal>To make that assessment, you need to look at the chart of performance data<o:p></o:p></p></div><div><p class=MsoNormal>points over time. By adding mini-charts with spark lines to the daily report<o:p></o:p></p></div><div><p class=MsoNormal>page, that human analysis can be done without having to open many separate<o:p></o:p></p></div><div><p class=MsoNormal>pages - speeding up that analysis massively.<o:p></o:p></p></div><div><p class=MsoNormal> <o:p></o:p></p></div><div><p class=MsoNormal>The attached patch implements adding such sparklines by adding SVG images<br>to the daily report page. For email reports this means that, this part probably<br>won't show up in most email clients. The only solution I can think of to also make<br>it work for email clients is to create images on the server - leading to more overloading of<o:p></o:p></p></div><div><p class=MsoNormal>the server & probably needing further dependencies on packages like matplotlib.<o:p></o:p></p></div><div><p class=MsoNormal>I think these sparklines are very useful – so already adding them to the webui is<br>worthwhile even if they don’t show up in the email report yet.<o:p></o:p></p></div><div><p class=MsoNormal> <o:p></o:p></p></div><div><p class=MsoNormal>Luckily, all the needed data for the sparklines was already loaded from the database by the<br>daily report generator – so adding these spark lines shouldn’t add much server overhead.<o:p></o:p></p></div><div><p class=MsoNormal> <o:p></o:p></p></div><div><p class=MsoNormal>A screenshot of a part of a daily report page with sparklines is below.<o:p></o:p></p></div><div><p class=MsoNormal> <o:p></o:p></p></div><div><p class=MsoNormal>Please review!<o:p></o:p></p></div><div><p class=MsoNormal> <o:p></o:p></p></div><div><p class=MsoNormal> <o:p></o:p></p></div><div><p class=MsoNormal><span style='mso-fareast-language:EN-GB'><image001.png></span><o:p></o:p></p></div><div><p class=MsoNormal> <o:p></o:p></p></div></div><p class=MsoNormal><span style='font-size:12.0pt;font-family:"Times New Roman","serif";mso-fareast-language:EN-GB'><0001-Add-spark-plots-to-the-daily-report-page.patch><o:p></o:p></span></p></div></blockquote></div><p class=MsoNormal><span style='font-size:12.0pt;font-family:"Times New Roman","serif";mso-fareast-language:EN-GB'><o:p> </o:p></span></p></div></div></div></body></html>