<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class="">LGTM. A few nits:</div><div class=""><br class=""></div><div class="">We are using PEP8 style in most files now. Grab the pep8 tool, it will do a good job picking out all the little things. That file was already clean.</div><div class=""><br class=""></div><div class="">Can you make the table headings and benchmark name row the correct number of columns? The spark cell just hangs off the side (for me).</div><div class=""><br class=""></div><img apple-inline="yes" id="4987160C-BC7E-46A8-AA95-72937173064A" height="120" width="640" apple-width="yes" apple-height="yes" src="cid:371B1003-B706-4B70-A621-FC7EF8231C25@hsd1.ca.comcast.net." class=""><div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Jun 16, 2015, at 10:08 AM, Kristof Beyls <<a href="mailto:kristof.beyls@arm.com" class="">kristof.beyls@arm.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><meta http-equiv="Content-Type" content="text/html; charset=us-ascii" class=""><meta name="Generator" content="Microsoft Word 14 (filtered medium)" class=""><!--[if !mso]><style>v\:* {behavior:url(#default#VML);}
o\:* {behavior:url(#default#VML);}
w\:* {behavior:url(#default#VML);}
.shape {behavior:url(#default#VML);}
</style><![endif]--><style class=""><!--
/* Font Definitions */
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";
mso-fareast-language:EN-US;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p.MsoAcetate, li.MsoAcetate, div.MsoAcetate
{mso-style-priority:99;
mso-style-link:"Balloon Text Char";
margin:0cm;
margin-bottom:.0001pt;
font-size:8.0pt;
font-family:"Tahoma","sans-serif";
mso-fareast-language:EN-US;}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:"Calibri","sans-serif";
color:windowtext;}
span.BalloonTextChar
{mso-style-name:"Balloon Text Char";
mso-style-priority:99;
mso-style-link:"Balloon Text";
font-family:"Tahoma","sans-serif";}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri","sans-serif";
mso-fareast-language:EN-US;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]--><div lang="EN-GB" link="blue" vlink="purple" class=""><div class="WordSection1"><div class="MsoNormal">In the daily report table, performance differences are highlighted as a single percentage<o:p class=""></o:p></div><div class="MsoNormal">difference. Due to the noise in many benchmarks and boards, often the true<o:p class=""></o:p></div><div class="MsoNormal">performance characteristic cannot be summarized well into a single percentage<o:p class=""></o:p></div><div class="MsoNormal">number, and a human has to look at all the samples/data points collected by the<o:p class=""></o:p></div><div class="MsoNormal">benchmarking runs to make a further assessment of whether a performance change<o:p class=""></o:p></div><div class="MsoNormal">should be categorized as "noise" or "real".<o:p class=""></o:p></div><div class="MsoNormal"><o:p class=""> </o:p></div><div class="MsoNormal">To make that assessment, you need to look at the chart of performance data<o:p class=""></o:p></div><div class="MsoNormal">points over time. By adding mini-charts with spark lines to the daily report<o:p class=""></o:p></div><div class="MsoNormal">page, that human analysis can be done without having to open many separate<o:p class=""></o:p></div><div class="MsoNormal">pages - speeding up that analysis massively.<o:p class=""></o:p></div><div class="MsoNormal"><o:p class=""> </o:p></div><div class="MsoNormal">The attached patch implements adding such sparklines by adding SVG images<br class="">to the daily report page. For email reports this means that, this part probably<br class="">won't show up in most email clients. The only solution I can think of to also make<br class="">it work for email clients is to create images on the server - leading to more overloading of<o:p class=""></o:p></div><div class="MsoNormal">the server & probably needing further dependencies on packages like matplotlib.<o:p class=""></o:p></div><div class="MsoNormal">I think these sparklines are very useful – so already adding them to the webui is<br class="">worthwhile even if they don’t show up in the email report yet.<o:p class=""></o:p></div><div class="MsoNormal"><o:p class=""> </o:p></div><div class="MsoNormal">Luckily, all the needed data for the sparklines was already loaded from the database by the<br class="">daily report generator – so adding these spark lines shouldn’t add much server overhead.<o:p class=""></o:p></div><div class="MsoNormal"><o:p class=""> </o:p></div><div class="MsoNormal">A screenshot of a part of a daily report page with sparklines is below.<o:p class=""></o:p></div><div class="MsoNormal"><o:p class=""> </o:p></div><div class="MsoNormal">Please review!<o:p class=""></o:p></div><div class="MsoNormal"><o:p class=""> </o:p></div><div class="MsoNormal"><o:p class=""> </o:p></div><div class="MsoNormal"><span style="mso-fareast-language:EN-GB" class=""><span id="cid:image001.png@01D0A85C.41CA50E0"><image001.png></span></span><o:p class=""></o:p></div><div class="MsoNormal"><o:p class=""> </o:p></div></div></div><span id="cid:91F4645E-0F34-4511-B8E5-EA88584CD232@hsd1.ca.comcast.net."><0001-Add-spark-plots-to-the-daily-report-page.patch></span></div></blockquote></div><br class=""></div></body></html>