<p dir="ltr">Apologies. Your sgtm sounded very much like you were fine with me committing.</p>
<p dir="ltr">I'll incorporate your more detailed review into a new commit.<br></p>
<p dir="ltr">Thanks. Diego.</p>
<div class="gmail_quote">On Jun 16, 2015 5:06 PM, "Duncan P. N. Exon Smith" <<a href="mailto:dexonsmith@apple.com">dexonsmith@apple.com</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
> On 2015-Jun-16, at 12:16, Diego Novillo <<a href="mailto:dnovillo@google.com">dnovillo@google.com</a>> wrote:<br>
><br>
> I fixed up the patch and committed it at r239843.<br>
><br>
> I'll continue working on this to use incoming edge masses. Duncan, please let me know if you notice anything else you'd like me to change as well.<br>
<br>
I'd rather you hadn't committed until I gave an LGTM (although I<br>
realize you may have just misread my SGTM). No need to revert --<br>
the churn doesn't seem worth it since the code changes look correct<br>
-- but have a look at my review comments in the thread for r239843.<br>
Mostly documentation and testcase changes.<br>
<br>
</blockquote></div>