<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Jun 10, 2015 at 4:27 PM, Sanjay Patel <span dir="ltr"><<a href="mailto:spatel@rotateright.com" target="_blank">spatel@rotateright.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: spatel<br>
Date: Wed Jun 10 18:27:33 2015<br>
New Revision: 239497<br>
<br>
URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject-3Frev-3D239497-26view-3Drev&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=QUIjgfvAm46yyruNsFJYodxwf-oT3JAdXiiPCd1zTXc&s=H3-IIvOjw0RMybwLKqLPgsWfDE1fYD4kEEPi4YkWcUg&e=" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=239497&view=rev</a><br>
Log:<br>
change assert that will never fire to llvm_unreachable<br>
<br>
Modified:<br>
    llvm/trunk/lib/Target/X86/X86InstrInfo.cpp<br>
<br>
Modified: llvm/trunk/lib/Target/X86/X86InstrInfo.cpp<br>
URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_llvm_trunk_lib_Target_X86_X86InstrInfo.cpp-3Frev-3D239497-26r1-3D239496-26r2-3D239497-26view-3Ddiff&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=QUIjgfvAm46yyruNsFJYodxwf-oT3JAdXiiPCd1zTXc&s=SVMygQYFUeWkeWqslz7USlbvKYBKdqNfZrEVBqW8zFw&e=" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86InstrInfo.cpp?rev=239497&r1=239496&r2=239497&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/Target/X86/X86InstrInfo.cpp (original)<br>
+++ llvm/trunk/lib/Target/X86/X86InstrInfo.cpp Wed Jun 10 18:27:33 2015<br>
@@ -6424,7 +6424,7 @@ void X86InstrInfo::genAlternativeCodeSeq<br>
            Pattern == MachineCombinerPattern::MC_REASSOC_XA_YB)<br>
     Prev = MRI.getUniqueVRegDef(Root.getOperand(2).getReg());<br>
   else<br>
-    assert("Unknown pattern for machine combiner");<br>
+    llvm_unreachable("Unknown pattern for machine combiner");<br></blockquote><div><br>Generally we try not to "branch to unreachable" & instead assert whatever the inverse of the branch condition was, so in this case:<br><br>if (AX_BY || XA_BY)<br>  ...<br>else {<br>  assert(AX_YB || XA_YB);<br>  ...<br>}<br><br>But sometimes it easier to read as an if/else if/else if/else if/else-unreachable chain... *shrug*<br> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
   reassociateOps(Root, *Prev, Pattern, InsInstrs, DelInstrs, InstIdxForVirtReg);<br>
   return;<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div></div>