<div dir="ltr">No.<div><br></div><div><div>$ dwarfdump missing >/dev/null ; echo $?</div><div>dwarfdump ERROR:  can't open missing</div><div>1</div></div><div><div>$ ./bin/llvm-dwarfdump missing >/dev/null ; echo $?</div><div>missing: No such file or directory</div><div>0</div></div><div><br></div><div>Do you agree we should change this (and <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_docs_CommandGuide_llvm-2Ddwarfdump.html&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=uJQM7xmPZyj_pjwpIBAMTkkHnZ7oCRZLXkNajqtlRYQ&s=NcoqPyi1YnndGp2T43MaavuW9LDsSMfyfmUwrKP7Vg0&e=">http://llvm.org/docs/CommandGuide/llvm-dwarfdump.html</a>)?</div><div><br></div><div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Jun 5, 2015 at 8:04 PM, Rafael Espíndola <span dir="ltr"><<a href="mailto:rafael.espindola@gmail.com" target="_blank">rafael.espindola@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><p dir="ltr">Interesting, does the regular dwarf dump also returns with 0?</p>
<p dir="ltr">Not that you changed it, I just noticed the test. </p>
<p dir="ltr">Thanks, <br>
Rafael </p><div class=""><div class="h5">
<div class="gmail_quote">On Jun 4, 2015 7:16 PM, "Alexey Samsonov" <<a href="mailto:vonosmas@gmail.com" target="_blank">vonosmas@gmail.com</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">Author: samsonov<br>
Date: Thu Jun  4 17:58:25 2015<br>
New Revision: 239113<br>
<br>
URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject-3Frev-3D239113-26view-3Drev&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=uJQM7xmPZyj_pjwpIBAMTkkHnZ7oCRZLXkNajqtlRYQ&s=uwAxtRHGg1FYtXnlE-X4D6iHsz_Le5wEQ1HIUXRa0cU&e=" target="_blank">http://llvm.org/viewvc/llvm-project?rev=239113&view=rev</a><br>
Log:<br>
[Object, ELF] Don't call llvm_unreachable() from createELFObjectFile.<br>
<br>
Instead, return a proper error code from factory.<br>
<br>
Added:<br>
    llvm/trunk/test/DebugInfo/Inputs/invalid.elf.2<br>
Modified:<br>
    llvm/trunk/lib/Object/ELFObjectFile.cpp<br>
    llvm/trunk/test/DebugInfo/dwarfdump-invalid.test<br>
<br>
Modified: llvm/trunk/lib/Object/ELFObjectFile.cpp<br>
URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_llvm_trunk_lib_Object_ELFObjectFile.cpp-3Frev-3D239113-26r1-3D239112-26r2-3D239113-26view-3Ddiff&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=uJQM7xmPZyj_pjwpIBAMTkkHnZ7oCRZLXkNajqtlRYQ&s=Wnc9F2whnmweVawcFX6wP335BiE9c5c8BQt0SLGknT4&e=" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Object/ELFObjectFile.cpp?rev=239113&r1=239112&r2=239113&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/Object/ELFObjectFile.cpp (original)<br>
+++ llvm/trunk/lib/Object/ELFObjectFile.cpp Thu Jun  4 17:58:25 2015<br>
@@ -38,7 +38,7 @@ ObjectFile::createELFObjectFile(MemoryBu<br>
     else if (Ident.second == ELF::ELFDATA2MSB)<br>
       R.reset(new ELFObjectFile<ELFType<support::big, false>>(Obj, EC));<br>
     else<br>
-      llvm_unreachable("Buffer is not an ELF object file!");<br>
+      return object_error::parse_failed;<br>
   } else {<br>
     assert(Ident.first == ELF::ELFCLASS64);<br>
     if (Ident.second == ELF::ELFDATA2LSB)<br>
@@ -46,7 +46,7 @@ ObjectFile::createELFObjectFile(MemoryBu<br>
     else if (Ident.second == ELF::ELFDATA2MSB)<br>
       R.reset(new ELFObjectFile<ELFType<support::big, true>>(Obj, EC));<br>
     else<br>
-      llvm_unreachable("Buffer is not an ELF object file!");<br>
+      return object_error::parse_failed;<br>
   }<br>
<br>
   if (EC)<br>
<br>
Added: llvm/trunk/test/DebugInfo/Inputs/invalid.elf.2<br>
URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_llvm_trunk_test_DebugInfo_Inputs_invalid.elf.2-3Frev-3D239113-26view-3Dauto&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=uJQM7xmPZyj_pjwpIBAMTkkHnZ7oCRZLXkNajqtlRYQ&s=itjmQg8oo3NHvCFGbYpZup7pvrB5S-DU4haHu0qzmMI&e=" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/DebugInfo/Inputs/invalid.elf.2?rev=239113&view=auto</a><br>
==============================================================================<br>
--- llvm/trunk/test/DebugInfo/Inputs/invalid.elf.2 (added)<br>
+++ llvm/trunk/test/DebugInfo/Inputs/invalid.elf.2 Thu Jun  4 17:58:25 2015<br>
@@ -0,0 +1 @@<br>
+ ELF 'L:þB“ ELF  ï<br>
\ No newline at end of file<br>
<br>
Modified: llvm/trunk/test/DebugInfo/dwarfdump-invalid.test<br>
URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_llvm_trunk_test_DebugInfo_dwarfdump-2Dinvalid.test-3Frev-3D239113-26r1-3D239112-26r2-3D239113-26view-3Ddiff&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=uJQM7xmPZyj_pjwpIBAMTkkHnZ7oCRZLXkNajqtlRYQ&s=5_9fznz1hQGc8t7oOnSty2HKxCcR97WLUS2b_qGwFGA&e=" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/DebugInfo/dwarfdump-invalid.test?rev=239113&r1=239112&r2=239113&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/test/DebugInfo/dwarfdump-invalid.test (original)<br>
+++ llvm/trunk/test/DebugInfo/dwarfdump-invalid.test Thu Jun  4 17:58:25 2015<br>
@@ -1,4 +1,5 @@<br>
 ; Verify that llvm-dwarfdump doesn't crash on broken input files.<br>
<br>
 RUN: llvm-dwarfdump %p/Inputs/invalid.elf 2>&1 | FileCheck %s --check-prefix=INVALID-ELF<br>
+RUN: llvm-dwarfdump %p/Inputs/invalid.elf.2 2>&1 | FileCheck %s --check-prefix=INVALID-ELF<br>
 INVALID-ELF: Invalid data was encountered while parsing the file<br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature"><div dir="ltr">Alexey Samsonov<br><a href="mailto:vonosmas@gmail.com" target="_blank">vonosmas@gmail.com</a></div></div>
</div></div></div>