<div dir="ltr">FYI, this causes a build failure with -Werror and -Wenum-compare:<div><br></div><div>lib/MC/MCSymbol.cpp:32:46: error: comparison between 'enum llvm::AlignOf<llvm::MCSymbol>::<anonymous>' and 'enum llvm::AlignOf<llvm::MCSymbol::NameEntryStorageTy>::<anonymous>' [-Werror=enum-compare]<br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Jun 9, 2015 at 1:58 PM, Pete Cooper <span dir="ltr"><<a href="mailto:peter_cooper@apple.com" target="_blank">peter_cooper@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: pete<br>
Date: Tue Jun  9 15:58:03 2015<br>
New Revision: 239431<br>
<br>
URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject-3Frev-3D239431-26view-3Drev&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=A3AtBjvd0F2ZXuH7fM7H83exqgFdkOTZuZePtHS-rR4&s=W191Am6OnqVvxgyiL9r19U8FTBbkvqwRk7OaTZcbfts&e=" target="_blank">http://llvm.org/viewvc/llvm-project?rev=239431&view=rev</a><br>
Log:<br>
Use AlignOf traits to enable static_assert.<br>
<br>
This is better than runtime asserts.  Thanks to David Blaikie for the help here.<br>
<br>
Modified:<br>
    llvm/trunk/lib/MC/MCSymbol.cpp<br>
<br>
Modified: llvm/trunk/lib/MC/MCSymbol.cpp<br>
URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_llvm_trunk_lib_MC_MCSymbol.cpp-3Frev-3D239431-26r1-3D239430-26r2-3D239431-26view-3Ddiff&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=A3AtBjvd0F2ZXuH7fM7H83exqgFdkOTZuZePtHS-rR4&s=ND2ehpkWhLcXxwnlAHsODVGYN4UZRPvlNM-9wHNiy7A&e=" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/MC/MCSymbol.cpp?rev=239431&r1=239430&r2=239431&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/MC/MCSymbol.cpp (original)<br>
+++ llvm/trunk/lib/MC/MCSymbol.cpp Tue Jun  9 15:58:03 2015<br>
@@ -28,9 +28,9 @@ void *MCSymbol::operator new(size_t s, c<br>
   // For safety, ensure that the alignment of a pointer is enough for an<br>
   // MCSymbol.  This also ensures we don't need padding between the name and<br>
   // symbol.<br>
-  // FIXME: Use static_assert when constexpr is supported.<br>
-  assert(alignOf<MCSymbol>() <= alignOf<NameEntryStorageTy>() &&<br>
-         "Bad alignment of MCSymbol");<br>
+  static_assert(AlignOf<MCSymbol>::Alignment <=<br>
+                AlignOf<NameEntryStorageTy>::Alignment,<br>
+                "Bad alignment of MCSymbol");<br>
   void *Storage = Ctx.allocate(Size, alignOf<NameEntryStorageTy>());<br>
   NameEntryStorageTy *Start = static_cast<NameEntryStorageTy*>(Storage);<br>
   NameEntryStorageTy *End = Start + (Name ? 1 : 0);<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>