<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Hi Ahmed,<br>
<br>
This patch added 3 new compiler-rt tests that include "fp_test.h".<br>
"fp_test.h" uses the __uint128_t type, which is not available on 32
bits. Some other tests also use the header but protect its include
with `#if __LDBL_MANT_DIG__ == 113`. The added tests don't do this,
so compilation fails.<br>
<br>
Would you consider adding similar protection to your tests, please?<br>
<br>
Thank you.<br>
Oleg<br>
<br>
<br>
<div class="moz-cite-prefix">12.05.2015 04:39, Ahmed Bougacha пишет:<br>
</div>
<blockquote
cite="mid:differential-rev-PHID-DREV-655d33vvbo7g3jf7p76y-req@reviews.llvm.org"
type="cite">
<pre wrap="">Hi scanon,
Mostly uninteresting, except:
- in __extendXfYf2, when checking if the number is normal, the current code relies on the unsignedness of src_rep_t, which is fine. Except that when sizeof(src_rep_t) < sizeof(int), the result gets promoted to int, the signedness of which breaks the comparison. I added an explicit cast to avoid that; it shouldn't affect other types.
- we can't just pass __fp16 around (you even get a clang error), so I made uint16_t explicit.
- is there a good way to define aliases (for the gnu_*_ieee names) ? Using the attribute, on darwin, clang complains about only weak aliases being supported, so I went with the simple def.
I also need to finish writing unit tests in compiler-rt proper (I paused when I realized lit+cmake isn't supported). In the meantime, opinions welcome.
<a class="moz-txt-link-freetext" href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_D9693&d=AwMDaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=h6m41veAaikH6DGylOlji4k_J9u0W5iwoI4w27_TSLQ&s=VJWIr8m7Lh26tX0pfMSnRETxaJIVohc4tuFft4fY5L8&e=">http://reviews.llvm.org/D9693</a>
Files:
lib/builtins/CMakeLists.txt
lib/builtins/extendhfsf2.c
lib/builtins/fp_extend.h
lib/builtins/fp_extend_impl.inc
lib/builtins/fp_trunc.h
lib/builtins/truncdfhf2.c
lib/builtins/truncsfhf2.c
EMAIL PREFERENCES
<a class="moz-txt-link-freetext" href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_settings_panel_emailpreferences_&d=AwMDaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=h6m41veAaikH6DGylOlji4k_J9u0W5iwoI4w27_TSLQ&s=ucufX12wdDop8xmEhyrV3yh-Ml6eVgQ6EilBQMuYp5Q&e=">http://reviews.llvm.org/settings/panel/emailpreferences/</a>
</pre>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
llvm-commits mailing list
<a class="moz-txt-link-abbreviated" href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a>
<a class="moz-txt-link-freetext" href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a>
</pre>
</blockquote>
<br>
</body>
</html>