<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 12 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-GB" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Hi James,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Thanks for the review.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Thanks,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Ranjeet<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span lang="EN-US" style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span lang="EN-US" style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> James Molloy [mailto:james@jamesmolloy.co.uk]
<br>
<b>Sent:</b> 08 June 2015 22:25<br>
<b>To:</b> reviews+D10320+public+67e11b9caa35016c@reviews.llvm.org; Ranjeet Singh<br>
<b>Cc:</b> kanheim@a-bix.com; llvm-commits@cs.uiuc.edu<br>
<b>Subject:</b> Re: [PATCH] Patch to make AArch64 AsmParser be case insensitive about accepting vector register names<o:p></o:p></span></p>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Hi Ranjeet,<br>
<br>
This looks good to me.<br>
<br>
Cheers,<br>
<br>
James<o:p></o:p></p>
<div>
<p class="MsoNormal">On Mon, 8 Jun 2015 at 21:44, Ranjeet Singh <<a href="mailto:ranjeet.singh@arm.com">ranjeet.singh@arm.com</a>> wrote:<o:p></o:p></p>
<p class="MsoNormal">The AArch64 AsmParser doesn't accept vector register names that start with an upper-case 'V'. GAS is case insensitive about these register names and so is armasm, this patch will make armclang behave the same way.<br>
<br>
<a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_D10320&d=AwMGaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=5Chx93OQ7RDg8wvmmAfSMgdfznFc1POtgsvAE2aZCKk&s=_0opbZ6_VmCbXYy6ZPcb3xqbtMJ8ZSXXd6l0wpK1Sw8&e=" target="_blank">http://reviews.llvm.org/D10320</a><br>
<br>
Files:<br>
lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp<br>
test/MC/AArch64/case-insen-reg-names.s<br>
<br>
Index: lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp<br>
===================================================================<br>
--- lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp<br>
+++ lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp<br>
@@ -1764,7 +1764,7 @@<br>
/// }<br>
<br>
static unsigned matchVectorRegName(StringRef Name) {<br>
- return StringSwitch<unsigned>(Name)<br>
+ return StringSwitch<unsigned>(Name.lower())<br>
.Case("v0", AArch64::Q0)<br>
.Case("v1", AArch64::Q1)<br>
.Case("v2", AArch64::Q2)<br>
Index: test/MC/AArch64/case-insen-reg-names.s<br>
===================================================================<br>
--- test/MC/AArch64/case-insen-reg-names.s<br>
+++ test/MC/AArch64/case-insen-reg-names.s<br>
@@ -0,0 +1,8 @@<br>
+// RUN: llvm-mc -triple aarch64-none-linux-gnu -show-encoding < %s | FileCheck %s<br>
+<br>
+fadd v0.2d, v5.2d, v6.2d<br>
+fadd V0.2d, V5.2d, V6.2d<br>
+fadd v0.2d, V5.2d, v6.2d<br>
+// CHECK: fadd v0.2d, v5.2d, v6.2d // encoding: [0xa0,0xd4,0x66,0x4e]<br>
+// CHECK: fadd v0.2d, v5.2d, v6.2d // encoding: [0xa0,0xd4,0x66,0x4e]<br>
+// CHECK: fadd v0.2d, v5.2d, v6.2d // encoding: [0xa0,0xd4,0x66,0x4e]<br>
<br>
EMAIL PREFERENCES<br>
<a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_settings_panel_emailpreferences_&d=AwMGaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=5Chx93OQ7RDg8wvmmAfSMgdfznFc1POtgsvAE2aZCKk&s=tlRvIc-XVJ_SfFAFzIbNJ09dt3eiQ7k3lTEKL6Myeu4&e=" target="_blank">
http://reviews.llvm.org/settings/panel/emailpreferences/</a><br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><o:p></o:p></p>
</div>
</div>
<br>
<font face="Arial" color="Black" size="2">-- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents
to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.<br>
<br>
ARM Limited, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2557590<br>
ARM Holdings plc, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2548782<br>
</font>
</body>
</html>