Hi Ranjeet,<br><br>This looks good to me.<br><br>Cheers,<br><br>James<br><div class="gmail_quote">On Mon, 8 Jun 2015 at 21:44, Ranjeet Singh <<a href="mailto:ranjeet.singh@arm.com">ranjeet.singh@arm.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">The AArch64 AsmParser doesn't accept vector register names that start with an upper-case 'V'. GAS is case insensitive about these register names and so is armasm, this patch will make armclang behave the same way.<br>
<br>
<a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_D10320&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=jCnnlD5zvC3Onv9U-akCwhYYoAlEBWTh_0WDVJeKG8c&s=-qcCNs03veI057V9vNVln3n5jEVpScEOgfqEojNvRiE&e=" target="_blank">http://reviews.llvm.org/D10320</a><br>
<br>
Files:<br>
  lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp<br>
  test/MC/AArch64/case-insen-reg-names.s<br>
<br>
Index: lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp<br>
===================================================================<br>
--- lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp<br>
+++ lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp<br>
@@ -1764,7 +1764,7 @@<br>
 /// }<br>
<br>
 static unsigned matchVectorRegName(StringRef Name) {<br>
-  return StringSwitch<unsigned>(Name)<br>
+  return StringSwitch<unsigned>(Name.lower())<br>
       .Case("v0", AArch64::Q0)<br>
       .Case("v1", AArch64::Q1)<br>
       .Case("v2", AArch64::Q2)<br>
Index: test/MC/AArch64/case-insen-reg-names.s<br>
===================================================================<br>
--- test/MC/AArch64/case-insen-reg-names.s<br>
+++ test/MC/AArch64/case-insen-reg-names.s<br>
@@ -0,0 +1,8 @@<br>
+// RUN: llvm-mc -triple aarch64-none-linux-gnu -show-encoding < %s | FileCheck %s<br>
+<br>
+fadd v0.2d, v5.2d, v6.2d<br>
+fadd V0.2d, V5.2d, V6.2d<br>
+fadd v0.2d, V5.2d, v6.2d<br>
+// CHECK: fadd v0.2d, v5.2d, v6.2d          // encoding: [0xa0,0xd4,0x66,0x4e]<br>
+// CHECK: fadd v0.2d, v5.2d, v6.2d          // encoding: [0xa0,0xd4,0x66,0x4e]<br>
+// CHECK: fadd v0.2d, v5.2d, v6.2d          // encoding: [0xa0,0xd4,0x66,0x4e]<br>
<br>
EMAIL PREFERENCES<br>
  <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_settings_panel_emailpreferences_&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=jCnnlD5zvC3Onv9U-akCwhYYoAlEBWTh_0WDVJeKG8c&s=I3ptUu-DyKS0CYjJau0a2zdTdfSFp_LsP4Ahg4T8ApM&e=" target="_blank">http://reviews.llvm.org/settings/panel/emailpreferences/</a><br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>