<div dir="rtl"><div dir="ltr">I don't think any of this would actually matter since all would be optimized away, but if anything, it's probably best to match GCSafepointPollName two code users which expect a StringRef by making this a static StringRef.</div><div dir="ltr"><br></div><div dir="ltr">In general, unless a null-terminated C string is actually required (for example, for OS API) StringRefs are always superior  to const char *. Just think about the easy mistake S == "some string".</div><div dir="ltr"><br></div></div><div class="gmail_extra"><br><div class="gmail_quote"><div dir="ltr">2015-06-07 19:36 GMT+03:00 Benjamin Kramer <span dir="ltr"><<a href="mailto:benny.kra@googlemail.com" target="_blank">benny.kra@googlemail.com</a>></span>:</div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: d0k<br>
Date: Sun Jun  7 11:36:28 2015<br>
New Revision: 239254<br>
<br>
URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject-3Frev-3D239254-26view-3Drev&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=D1Q2NS_ZFZgYJ5WXDcMWuLkuUZ-Qct8p9fplxmqUqRk&s=BlmmYrjRrWAjfBHo_9twTQUkLfxsYxWt9bjA2yIhqA4&e=" target="_blank">http://llvm.org/viewvc/llvm-project?rev=239254&view=rev</a><br>
Log:<br>
Remove global std::string. NFC.<br>
<br>
Modified:<br>
    llvm/trunk/lib/Transforms/Scalar/PlaceSafepoints.cpp<br>
<br>
Modified: llvm/trunk/lib/Transforms/Scalar/PlaceSafepoints.cpp<br>
URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_llvm_trunk_lib_Transforms_Scalar_PlaceSafepoints.cpp-3Frev-3D239254-26r1-3D239253-26r2-3D239254-26view-3Ddiff&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=D1Q2NS_ZFZgYJ5WXDcMWuLkuUZ-Qct8p9fplxmqUqRk&s=RMAt1vLTphkawhIss2Np6sV_XBs1zuhWNQ6iSl12F9Y&e=" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Scalar/PlaceSafepoints.cpp?rev=239254&r1=239253&r2=239254&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/Transforms/Scalar/PlaceSafepoints.cpp (original)<br>
+++ llvm/trunk/lib/Transforms/Scalar/PlaceSafepoints.cpp Sun Jun  7 11:36:28 2015<br>
@@ -496,7 +496,7 @@ template <typename T> static void unique<br>
   }<br>
 }<br>
<br>
-static std::string GCSafepointPollName("gc.safepoint_poll");<br>
+static const char *const GCSafepointPollName = "gc.safepoint_poll";<br>
<br>
 static bool isGCSafepointPoll(Function &F) {<br>
   return F.getName().equals(GCSafepointPollName);<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>